Repository navigation
fix: add watch verb on clusterroles and clusterrolebindings for feast-operator - #7062
Open
ryder777777 wants to merge 1 commit into
Open
ryder777777 wants to merge 1 commit into
ryder777777 wants to merge 1 commit into
Conversation
…-operator Signed-off-by: ryder777777 <sahilridder@gmail.com>
patelchaitany
approved these changes
Oct 27, 2026
patelchaitany
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Just something to keep in mind: watch on clusterroles and clusterrolebindings was removed in #6736 as part of narrowing the RBAC permissions. It may have been an oversight given the cached client's requirements, but I'm not sure whether that removal was intentional.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
controller-runtime's default cached client starts informers (List+Watch) the first timeGet/Listis called on a resource type. Currently, the Feast Operator'smanager-roleClusterRolegrantsgetandlistonclusterrolesandclusterrolebindingsinrbac.authorization.k8s.io, but omitswatch, causing the informer reflectors to fail withFailed to watch *v1.ClusterRole: ... cannot watch resource "clusterroles"andFailed to watch *v1.ClusterRoleBinding: ... cannot watch resource "clusterrolebindings".This PR adds the
watchverb toclusterrolesandclusterrolebindingsinfeaturestore_controller.go's kubebuilder RBAC markers and synced manifests (config/rbac/role.yaml,dist/install.yaml, andbundle/manifests/feast-operator.clusterserviceversion.yaml).Which issue(s) this PR fixes:
Fixes #7061
Checks
git commit -s)Testing Strategy