Repository navigation
Conversation
Signed-off-by: AryanRG <aryanrganjoo@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a source created timestamp shares a name with a request column, Dask historical retrieval can read the request value instead. This can include a backfill created after the query time or remove a request column from the result.
Keep the source timestamp under a temporary name that cannot collide with request or feature columns. Regression tests cover timestamp filtering, preserved request data and multiple feature views.
Which issue(s) this PR fixes:
No existing issue.
Checks
git commit -s)Testing Strategy
Focused tests and neighboring Dask tests pass, along with scoped Ruff and mypy checks. The regression uses local Parquet files through the public FeatureStore API.