Repository navigation
fix: Refresh pre-computed vectors for pushed entities only and match bare feature names - #7076
Open
chandlerok wants to merge 2 commits into
Open
chandlerok wants to merge 2 commits into
chandlerok wants to merge 2 commits into
Conversation
precompute_feature_service accepts entity_keys and skips the keyspace scan when they are given. The push hook now passes the distinct entity keys from the pushed DataFrame instead of rebuilding every entity in the store. Signed-off-by: Chandler King <chandler.king@findheadway.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Stored vectors carry "<fv>__<feature>" names while the default request expects bare feature names, so the fast path always reported a schema mismatch unless full_feature_names=True. Compare on the caller's naming and derive the per-feature view name from the stored names for TTL checks. Signed-off-by: Chandler King <chandler.king@findheadway.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chandlerok
requested review from
franciscojavierarceo,
nquinn408 and
shuchu
and removed request for
a team
October 26, 2026 23:19
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7076 +/- ##
==========================================
+ Coverage 50.97% 51.00% +0.02%
==========================================
Files 455 455
Lines 56994 57012 +18
Branches 8321 8324 +3
==========================================
+ Hits 29055 29077 +22
+ Misses 25954 25950 -4
Partials 1985 1985
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Two fixes that make
precompute_online=Trueusable on a store that takes pushes.precompute_feature_servicetakesentity_keys. When given, it rebuilds only those entities and skips the keyspace scan._precompute_for_pushpasses the distinct keys from the pushed frame, so the cost scales with the push, not the store._try_precomputed_fast_pathcompares names on the caller's naming. Vectors store<fv>__<feature>; with the defaultfull_feature_names=Falsethe request expects bare names, so the fast path reported a schema mismatch on every read andget_online_featuresraised. The per-view name used for TTL checks is taken from the stored names.One
store.pushof 1 row on a Redis store with 200 entities, one precompute service registered, Feast 0.67.0, registry cache off so every row is measured the same way:With the default registry cache the same push on this PR is 3.7 ms; the 51 to 58 ms floor above is the registry proto rebuild that
allow_registry_cache=Falseforces, not the vector write.Which issue(s) this PR fixes:
Fixes #7074
Checks
git commit -s)Testing Strategy
New unit tests: push hook passes de-duplicated entity keys and skips when the frame has no join key columns; fast path matches and reorders bare names with
full_feature_names=False(both fail on master).test_precomputed_feature_vectors.pypasses locally.Misc
@ntkathole this is the first of two follow-ups to #6463; the second (#7075) stacks on it.
🤖 Generated with Claude Code