Repository navigation
Build on the region renderer from django-content-editor - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to feincms/django-content-editor#65, which moves the region renderer into
content_editor.rendererand adds containers (plugins nesting other plugins using an explicitdepth). Seespecs/explicit-container-tree.mdthere for the release plan: both land together, django-content-editor 10.0 and this.feincms3.rendererre-exportscontent_editor.renderer(RegionRenderer,template_renderer,render_in_context,default_context,PluginNotRegisteredError), so existing imports keep working. ItsRegionRenderersubclass only keeps the deprecated compatibility APIs (TemplatePluginRenderer,register_string_renderer,register_template_renderer,render_plugin_in_context,handlers) and closer-based section rendering.RegionRendererrenders containers now, inherited from django-content-editor.render_section_plugins,register_section_close) emits aDeprecationWarning; content is migrated usingcontent_editor.migrations_utils.compute_depths.Blocked on django-content-editor 10.0 being released: CI and the docs build install django-content-editor from PyPI, where
content_editor.rendererdoesn't exist yet. Tested locally against the django-content-editor branch (all tests pass, docs build without warnings).🤖 Generated with Claude Code