Repository navigation
Only pull the full pipeline if refresh_version changed - #3437
Conversation
|
whats the impact of closed loop polling on the perf graphs if the connection is bad? |
|
@gz assuming desired graphs data points interval (1 second) is T: if the request resolves faster than T - the graphs data points interval remains T; if the request resolves slower than T - the next request is issued as soon as the previous one resolves; if the request fails - graphs stop updating until the first successful request, then the graphs timeline jumps to the current time with the straight line connecting the previous and the new value |
93fa5ea to
96b16f6
Compare
gz
left a comment
There was a problem hiding this comment.
rather than having all these popups on every failed call can we just have one red box that shows up whenever we have connection issues
|
I will consider displaying a single network connection error instead of separate messages in a separate PR, the best implementation is not obvious |
|
ok maybe check with anna whats good for this too |
|
For connection errors (the client being unable to get a response from the API server) it could show messages like "Connectivity lost" or something as you have above, for any of the errors where the API server does respond with an ErrorResponse, it would be invaluable to have both the |
83c6b4b to
f29d3d8
Compare
|
I refactored logs tab to support a more consistent copy-paste experience:
|
|
I will address a high-level "Network connection issue" notification in a separate PR |
|
I haven't looked at this, but I really like the github design where some text boxes have a "copy" icon on top-right. |
|
Could you post a screenshot? Not sure what you are referring to. |
|
Would that be "Copy all logs" button? I can add it, but Ctrl+A works just fine now |
|
the point of this design is that each window or text area with something to copy has its own button. |
|
I love this design; compare to slack, where copying something is a pain. |
869ca24 to
9611b86
Compare
9611b86 to
0233c5d
Compare
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Remove some obsolete code Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…changed Implement closed loop polling of pipeline status Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…k-to-bottom behavior Fix logs coloring Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…s by pre-building icons Remove PLAYWRIGHT_SNAPSHOTS_COMMIT var from Earthly .arg file Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…l + A for errors tab Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Fix crash when navigating to error before opening related file Fix comment shortcut in Firefox on AZERTY layout Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
afac8f7 to
bd960ad
Compare


Make polling of the pipeline list "closed-loop" - waiting for the previous request to resolve before issuing the next one
Fix #3417: Only full refresh if refresh_version changed
Fix #3375: Copying doesn't work well in the log tab
Fix stderr not displayed on some system errors
Fix type errors not reported in production build
Fix #3416: Make HTTP request errors pop up as toast notifications (Display client-side errors in toast notifications)
Fix #3375: Copying doesn't work well in the log tab
Fix https://github.com/feldera/cloud/issues/501: Out-of-memory during build due to vite-svg-2-webfont
Fix #3403: Improve the UX of errors tab
Fix #3380: Add keyboard shortcut in editor to (un)comment code
Fix #3242: Edits to udf.rs are reverted when things are compiling