← 输入框|github.com|刷新
Skip to content

Only pull the full pipeline if refresh_version changed - #3437

Merged
Karakatiza666 merged 16 commits into
mainfrom
fix-ui
Feb 13, 2025
Merged

Karakatiza666 merged 16 commits into
mainfrom
fix-ui

Conversation

@Karakatiza666

@Karakatiza666 Karakatiza666 commented Jan 30, 2025 •

Copy link
Copy Markdown
Contributor

Make polling of the pipeline list "closed-loop" - waiting for the previous request to resolve before issuing the next one
Fix #3417: Only full refresh if refresh_version changed
Fix #3375: Copying doesn't work well in the log tab
Fix stderr not displayed on some system errors
Fix type errors not reported in production build
Fix #3416: Make HTTP request errors pop up as toast notifications (Display client-side errors in toast notifications)
Fix #3375: Copying doesn't work well in the log tab
Fix https://github.com/feldera/cloud/issues/501: Out-of-memory during build due to vite-svg-2-webfont
Fix #3403: Improve the UX of errors tab
Fix #3380: Add keyboard shortcut in editor to (un)comment code
Fix #3242: Edits to udf.rs are reverted when things are compiling

@gz

gz commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

whats the impact of closed loop polling on the perf graphs if the connection is bad?

@Karakatiza666

Copy link
Copy Markdown
Contributor Author

image

@Karakatiza666

Karakatiza666 commented Feb 3, 2025 •

Copy link
Copy Markdown
Contributor Author

@gz assuming desired graphs data points interval (1 second) is T: if the request resolves faster than T - the graphs data points interval remains T; if the request resolves slower than T - the next request is issued as soon as the previous one resolves; if the request fails - graphs stop updating until the first successful request, then the graphs timeline jumps to the current time with the straight line connecting the previous and the new value

@Karakatiza666
Karakatiza666 force-pushed the fix-ui branch 5 times, most recently from 93fa5ea to 96b16f6 Compare February 3, 2025 21:32

@gz gz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than having all these popups on every failed call can we just have one red box that shows up whenever we have connection issues

@Karakatiza666

Copy link
Copy Markdown
Contributor Author

I will consider displaying a single network connection error instead of separate messages in a separate PR, the best implementation is not obvious

@gz

gz commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

ok maybe check with anna whats good for this too

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Feb 4, 2025
@snkas

snkas commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

For connection errors (the client being unable to get a response from the API server) it could show messages like "Connectivity lost" or something as you have above, for any of the errors where the API server does respond with an ErrorResponse, it would be invaluable to have both the error_code (e.g., PipelineInteractionUnreachable) as well as the message to show. Of course, this should exclude the errors the UI expects/handles by itself.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@Karakatiza666
Karakatiza666 force-pushed the fix-ui branch 2 times, most recently from 83c6b4b to f29d3d8 Compare February 6, 2025 19:41
@Karakatiza666

Copy link
Copy Markdown
Contributor Author

I refactored logs tab to support a more consistent copy-paste experience:

  • Ctrl+A selects the entire buffer of logs in browser memory
  • After selecting multiple rows and scrolling away you can scroll back to your selection, or Ctrl+C while the selected text is off-screen

@Karakatiza666

Copy link
Copy Markdown
Contributor Author

I will address a high-level "Network connection issue" notification in a separate PR

@mihaibudiu

Copy link
Copy Markdown
Contributor

I haven't looked at this, but I really like the github design where some text boxes have a "copy" icon on top-right.

@Karakatiza666

Copy link
Copy Markdown
Contributor Author

Could you post a screenshot? Not sure what you are referring to.

@mihaibudiu

Copy link
Copy Markdown
Contributor

image

@Karakatiza666

Copy link
Copy Markdown
Contributor Author

Would that be "Copy all logs" button? I can add it, but Ctrl+A works just fine now

@mihaibudiu

Copy link
Copy Markdown
Contributor

the point of this design is that each window or text area with something to copy has its own button.
No need to click to focus, CTRL-A, CTRL-C to copy.
I would add this to all windows that hold code or logs, or to fda output.
Not sure about the changes.

@mihaibudiu

Copy link
Copy Markdown
Contributor

I love this design; compare to slack, where copying something is a pain.

@Karakatiza666
Karakatiza666 force-pushed the fix-ui branch 2 times, most recently from 869ca24 to 9611b86 Compare February 11, 2025 16:42
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Feb 11, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Remove some obsolete code

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…changed

Implement closed loop polling of pipeline status

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…k-to-bottom behavior

Fix logs coloring

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…s by pre-building icons

Remove PLAYWRIGHT_SNAPSHOTS_COMMIT var from Earthly .arg file

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
…l + A for errors tab

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Fix crash when navigating to error before opening related file

Fix comment shortcut in Firefox on AZERTY layout

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants