Repository navigation
[profiler] Display by default only "basic" metrics in the profiler - #7770
Conversation
|
The next step is to use these features to implement #7296 |
|
What I ran
Issues
|
|
You should've consulted @AnnaZhand regarding adding the shadows to toggles. Anna can we do anything regarding the segment indicator appearance, or we should leave it alone until the redesign? |
|
The shadows are a very small part of this PR, which is easy to change. But even I found these buttons puzzling, it's not obvious what you can do with them with the flat look, so I made them look more like buttons, to make it clear you can press them. |
|
No, I understand the intention; we just need to run that through Anna; I imagine this change is out-of-place. I am reviewing the rest in the meantime. |
|
"Basic | Standard | Advanced" looks too involved to me. If it were me I'd have either "Basic| All" or "Standard | Advanced", where the names don't necessarily correspond to what these groups include now. I would ask to reconsider if the user really need three choices. E.g. I would argue if we are doing this for the sake of making it simpler for the new users, "Basic | All" would be better: "Basic" for new users, "All" to not have experienced users guess whether the metric they are interested in will show up in "Standard" or not |
|
Let's don't add additional shadow to segmented control in this particular place. Lets bring it as a common concern and refresh style of segmented control across all UI |
|
Given this Claude should completely cut out the new |
Karakatiza666
left a comment
There was a problem hiding this comment.
Other than the comments and discussed indicator shadow revert - LGTM
For this let's see what @xiasongh thinks |
|
I will push a new version which does the following:
|
ea14073 to
34c6f72
Compare
|
idk how useful a "basic" view is. the profiler is already an advanced tool and should cater towards the typical user of the profiler, so i lean towards showing more if there's too much info, we could add a field filter/sort + save in local storage so people can decide for themselves what's useful to them? |
|
I am also in favor of having two categories: basic & advanced. If we do keep three categories, I'd propose adding some memory usage metrics to the basic view. Long term, I hope that our goal is to have users spend less time investigating the profiles via the UI. These days, agents are commonly used to investigate support bundles, analyze bottlenecks, etc. |
|
In this case I will amend the PR to remove the "advanced" bit from the Rust data structure, since it's not useful, and I will add something about memory to "basic" |
dc1aaff to
ceef3be
Compare
|
Verdict: PR bug (high confidence) — a leftover e2e assertion, not a product bug. Evidence
Fix on Take it with: Compare: basic-metrics...fred/observe-7770-41995612215 Only this one e2e assertion needed updating; nothing else in the failed job pointed at a real regression. |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
…tput nodes Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
ceef3be to
80f01e6
Compare
This PR has 8 different commits which make small improvements to the profiler.
Only some of them are visual. Others do some code cleanup and improve a very inefficient graph construction phase from quadratic to linear.
Here are some visual improvements:
Some UI elements now have pop-up titles on hover:
When the graph layout is recomputed the "computing layout" message appears much faster, it appears close to the mouse, and is much more visible; it used to appear in the minimap, where it could be ignored:
The biggest change however is to divide metrics display into 2 choices: basic/advanced. The basic metrics only show 4 essential metrics: time, memory, storage, input records. The drop-down also makes it much clearer which one is the currently selected metric (previously the behavior was rather strange). You can see them listed in the previous screenshot.
The display of the basic metrics looks as follows:
Describe Manual Test Plan
I have extracted the following screenshots from the improved profiler.
Checklist