← 输入框|github.com|刷新
Skip to content

[profiler] Do not draw the edges into the multihost remote waiter - #7771

Merged
mihaibudiu merged 1 commit into
mainfrom
issue7243
Nov 2, 2026
Merged

mihaibudiu merged 1 commit into
mainfrom
issue7243

Conversation

@mihaibudiu

Copy link
Copy Markdown
Contributor

Linked Issue

Fixes #7243

Ignore all in-edges to a node with operation ShardedAccumulatorRemoteWaiter when drawing a profile.

Describe Manual Test Plan

Ran the profiler manually

Checklist

  • Unit tests added/updated

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu
mihaibudiu requested a review from ryzhyk November 1, 2026 06:47
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM.

Checked the edge direction against add_sharded_accumulator_receiver in crates/dbsp/src/operator/dynamic/sharded_accumulator.rs. Each receiver gets add_dependency(receiver, remote_waiter), so the edges point receiver → waiter. Dropping the edges whose target is the waiter therefore removes all of them. Splitting the label on @ and calling trim() works whether or not the label has a location suffix.

Ran Result
vitest --run src/profile.test.ts 168/168 pass
New test with the profile.ts change reverted fails as expected, so the test guards the fix
Full profiler-lib vitest --run 2 failures in viewport.test.ts (zoom 1 vs 0.9375). These also fail without this PR's change, so they are not caused by it.

@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 288cd64 Nov 2, 2026
3 checks passed
@mihaibudiu
mihaibudiu deleted the issue7243 branch November 2, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[profiler] Profiler issues on multihost

2 participants