← 输入框|github.com|刷新
Skip to content

Add rclone to our devcontainer and Docker image - #7774

Merged
llogiq merged 1 commit into
mainfrom
rclone
Nov 2, 2026
Merged

llogiq merged 1 commit into
mainfrom
rclone

Conversation

@llogiq

@llogiq llogiq commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This is just a small addition to our Dockerfiles, to aid a change in the cloud repo.

Comment thread deploy/Dockerfile Resolved
Comment thread deploy/Dockerfile Outdated
# Used to set capabilities to the samply profiler
libcap2-bin
libcap2-bin \
# rclone is used by cloud's sync-checkpoint crate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitfall (medium): Ubuntu 24.04's apt rclone is 1.60.x, from late 2022. Please check that the flags the checkpoint-sync code passes (see extra flags / S3 / GCS options in crates/feldera-types/src/config.rs) work on that version. If they don't, pin a newer release by downloading the official .deb with a checksum. A newer build also helps with the FIPS rule: the distro's Go build uses Go's own crypto/TLS rather than aws-lc, so please confirm that's acceptable for the shipped image.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. There are two options that are unsupported in 1.60. I'll change the images to include a current version instead.

@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Review summary

Check Result
sh -n on the changed RUN snippet in deploy/Dockerfile ❌ fails: unterminated quote (see inline)
Docker build not run (no Docker daemon here)
.devcontainer/Dockerfile change ✅ looks fine
Licensing ✅ rclone is MIT
  • bug (critical): the stray ' in deploy/Dockerfile breaks the image build. Please don't merge until it's fixed and the docker CI job passes.
  • missing (medium), manual testing: the PR description doesn't say how this was checked. Please confirm that the built image runs rclone version and that the rclone version Ubuntu ships works with the checkpoint-sync flags (see inline).
  • pitfall (low/medium): rclone adds roughly 50–60 MB to the shipped OSS image only so a downstream image can use it. Consider installing it in that downstream image instead, or say in the commit message why the OSS image needs it.
  • commit message: the subject should be capitalized: Add rclone to devcontainer and Docker image.

@llogiq
llogiq force-pushed the rclone branch 2 times, most recently from cdd2189 to 92d335c Compare November 1, 2026 16:55
@llogiq llogiq changed the title add rclone to our devcontainer and docker image Add rclone to our devcontainer and Docker image Nov 1, 2026
@llogiq
llogiq added this pull request to the merge queue Nov 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 1, 2026
@llogiq
llogiq added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026
@llogiq
llogiq added this pull request to the merge queue Nov 2, 2026
@gz

gz commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Merged via the queue into main with commit 4b6d3b4 Nov 2, 2026
1 check passed
@llogiq
llogiq deleted the rclone branch November 2, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants