Repository navigation
[pipeline-manager] keep the bootstrap config through a stop request in the model. - #7779
Merged
Merged
Conversation
…n the model A stop request clears `bootstrap_policy` together with `deployment_initial` only while the pipeline is still `Stopped`; otherwise both stay until the pipeline becomes `Stopping`. The implementation does this, and the pipeline lifecycle docs specify it. The model's two desired-`Stopped` setters cleared `bootstrap_policy` unconditionally, so `db_impl_behaves_like_model` failed whenever its generator stopped a `Provisioning` pipeline and read it back. `stop_request_keeps_bootstrap_config_of_started_deployment` pins both setters deterministically; the property test never calls the forced one. Fixes #7666 Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Contributor
|
LGTM. The model fix matches
Observation: with the default stack, |
mihaibudiu
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stop request clears
bootstrap_policytogether withdeployment_initialonly while the pipeline is stillStopped; otherwise both stay until the pipeline becomesStopping. The implementation does this, and the pipeline lifecycle docs specify it. The model's two desired-Stoppedsetters clearedbootstrap_policyunconditionally, sodb_impl_behaves_like_modelfailed whenever its generator stopped aProvisioningpipeline and read it back.stop_request_keeps_bootstrap_config_of_started_deploymentpins both setters deterministically; the property test never calls the forced one.Linked Issue
Fixes #7666
Describe Manual Test Plan
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes