← 输入框|github.com|刷新
Skip to content

[docs] Document pipeline.allowLocalFileUris - #7780

Merged
swanandx merged 1 commit into
mainfrom
docs-allow-local-file-uris
Nov 3, 2026
Merged

swanandx merged 1 commit into
mainfrom
docs-allow-local-file-uris

Conversation

@swanandx

@swanandx swanandx commented Nov 2, 2026

Copy link
Copy Markdown
Member

Adds pipeline.allowLocalFileUris to the Helm chart reference. The option refuses local paths in Delta Lake and Iceberg connectors.

Linked Issue

None.

Describe Manual Test Plan

Docs only. The text matches the chart behavior in 0.373.0.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

None.

The Helm chart has this option since 0.373.0, but the Helm reference did not list it.

Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
@swanandx
swanandx requested a review from gz November 2, 2026 08:26
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This is a docs-only change, so the test gates don't apply.

What I ran

  • pre-commit run --files helm-chart-reference.md passed.
  • cargo test -p feldera-types local_file_uri passed.
  • I checked the new row against TransportConfig::local_file_uris and resolve_connector_config in crates/connectors/src/controller.rs. The row matches what the code does:
    • Covered connectors: Delta input and output (uri), and Iceberg input (metadata_location, glue.warehouse).
    • What counts as local: a file: URL or a value with no scheme.
    • When it applies: the connector fails when it is created, and the check also runs on values that come from secrets.
  • The Helm chart isn't in this repo, so I couldn't confirm the true default or that the chart maps the option to FELDERA_REFUSE_LOCAL_FILE_URIS.

missing (medium): docs/connectors/sources/iceberg.md:110 still lists file:// / no prefix as supported, and the Delta pages don't mention the restriction. Users on a locked-down deployment will hit a startup error that those pages don't explain. A one-line note on each page linking to this Helm option, and naming the env var for deployments that don't use Helm, would close that gap.

@swanandx
swanandx enabled auto-merge November 2, 2026 14:37
@swanandx
swanandx disabled auto-merge November 2, 2026 18:29
@swanandx
swanandx added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026
@swanandx
swanandx added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit df49e3b Nov 3, 2026
3 checks passed
@swanandx
swanandx deleted the docs-allow-local-file-uris branch November 3, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants