Repository navigation
[SQL] ShareIndexes: only share indexes that read the same output port - #7784
Merged
mihaibudiu merged 1 commit intoNov 2, 2026
Merged
mihaibudiu merged 1 commit into
mihaibudiu merged 1 commit into
Conversation
FindSharedIndexes looks for sibling MapIndex operators with graph.getSuccessors(input.node()). The graph records edges per operator, not per output port, so for a multi-output producer (such as the nested operator of two mutually recursive views) the siblings include indexes over different outputs. The grouping checked key and value nullability but not the port, so ReplaceSharedIndexes built a single index from the first port and gave it to consumers of the other port, which then silently read the wrong stream. Skip a sibling unless it reads the same OutputPort (operator and port number). Indexes over the same port are still shared. The new SharedIndexPortTests joins each of two same-typed mutually recursive views to a table (cross join and equi-join). Before the fix out_b returns a's rows; with it both views are correct. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: bens-secret-alt-account <255422042+bens-secret-alt-account@users.noreply.github.com>
mihaibudiu
enabled auto-merge
November 2, 2026 17:33
mihaibudiu
disabled auto-merge
November 2, 2026 17:57
mihaibudiu
enabled auto-merge
November 2, 2026 17:57
mihaibudiu
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #7783
FindSharedIndexesfound siblingMapIndexoperators by producer operator, so for a multi-output operator (here the nested operator of two mutually recursive views) it could merge indexes over different outputs, and one view read the other's rows. This skips a sibling unlesssmi.input().equals(input), i.e. same operator and same port.AI use: Claude Code (Opus 5.5) found the bug, wrote the fix and the test, and ran them.
Describe Manual Test Plan
Added
SharedIndexPortTests(cross-join and equi-join over two mutually recursive views). Onmainat 4b6d3b4 both fail without_breturninga's rows; with the fix they pass, and the existingShareIndexesTests(16) still pass. Did not run the full compiler suite.Checklist
Breaking Changes?
None.