← 输入框|github.com|刷新
Skip to content

[SQL] ShareIndexes: only share indexes that read the same output port - #7784

Merged
mihaibudiu merged 1 commit into
feldera:mainfrom
bens-secret-alt-account:codex/shareindexes-port-check
Nov 2, 2026
Merged

mihaibudiu merged 1 commit into
feldera:mainfrom
bens-secret-alt-account:codex/shareindexes-port-check

Conversation

@bens-secret-alt-account

Copy link
Copy Markdown
Contributor

Linked Issue

Closes #7783

FindSharedIndexes found sibling MapIndex operators by producer operator, so for a multi-output operator (here the nested operator of two mutually recursive views) it could merge indexes over different outputs, and one view read the other's rows. This skips a sibling unless smi.input().equals(input), i.e. same operator and same port.

AI use: Claude Code (Opus 5.5) found the bug, wrote the fix and the test, and ran them.

Describe Manual Test Plan

Added SharedIndexPortTests (cross-join and equi-join over two mutually recursive views). On main at 4b6d3b4 both fail with out_b returning a's rows; with the fix they pass, and the existing ShareIndexesTests (16) still pass. Did not run the full compiler suite.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

None.

FindSharedIndexes looks for sibling MapIndex operators with
graph.getSuccessors(input.node()). The graph records edges per operator, not
per output port, so for a multi-output producer (such as the nested operator
of two mutually recursive views) the siblings include indexes over different
outputs. The grouping checked key and value nullability but not the port, so
ReplaceSharedIndexes built a single index from the first port and gave it to
consumers of the other port, which then silently read the wrong stream.

Skip a sibling unless it reads the same OutputPort (operator and port number).
Indexes over the same port are still shared.

The new SharedIndexPortTests joins each of two same-typed mutually recursive
views to a table (cross join and equi-join). Before the fix out_b returns a's
rows; with it both views are correct.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Signed-off-by: bens-secret-alt-account <255422042+bens-secret-alt-account@users.noreply.github.com>
@mihaibudiu
mihaibudiu disabled auto-merge November 2, 2026 17:58
@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 2, 2026
Merged via the queue into feldera:main with commit 6bdf803 Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SQL] ShareIndexes merges indexes on different outputs of a recursive view

2 participants