Repository navigation
[python] Use only real storage and volume attributes classes in tests - #7790
Conversation
| API_PREFIX = "/v0" | ||
|
|
||
| # A storage class the installation allows. Set it where the API has a storage class allowlist. | ||
| STORAGE_CLASS = os.environ.get("FELDERA_TEST_STORAGE_CLASS", "example") |
There was a problem hiding this comment.
missing (medium): check_storage (crates/pipeline-manager/src/config.rs) has a second allowlist of the same kind, kubernetesRunner.volumeAttributesClassNamesSupported. test_volume_attributes_class_edit_with_storage (test_pipeline_lifecycle.py:781) still hardcodes "example", so it will fail the same way on an installation that turns that allowlist on. Could you add a matching FELDERA_TEST_VOLUME_ATTRIBUTES_CLASS here and use it in that test, so this doesn't need a second PR?
|
Summary: This is a test-only change. It lets the platform tests read the storage class from
No feldera-pr-checks gates fail. LGTM once the volume-attributes test is handled or tracked separately. |
|
LGTM. This is a test-only change. The new knob follows the existing What I ran
|
An api-server with an allowlist refuses the old fixed names. Tests read the classes from FELDERA_TEST_STORAGE_CLASS and FELDERA_TEST_VOLUME_ATTRIBUTES_CLASS and skip those checks when unset.
6bef734 to
de09028
Compare
The api-server refuses a
storage_classorvolume_attributes_classoutside its allowlist (#7712). Some platform tests used made-up names (normal,example), so they fail on an installation with an allowlist, such as cloud CI.test_pipeline_runtime_configstorage_classcase removedtest_runtime_config_edit_restrictedstorage_classstep readsFELDERA_TEST_STORAGE_CLASS; skipped when unsettest_volume_attributes_class_edit_with_storageFELDERA_TEST_VOLUME_ATTRIBUTES_CLASS; skipped when unsetNo defaults, so no test sends a class the installation does not have. Cloud CI sets
FELDERA_TEST_STORAGE_CLASSin feldera/cloud#2144.Tested on k3d with the storage class allowlist set to
local-path:test_pipeline_runtime_configpasses. The restricted-edit and volume attributes tests were not run (they need a compile, which does not work on that cluster, and k3d has no VolumeAttributesClass).