← 输入框|github.com|刷新
Skip to content

[SQL] Several small improvements - #7794

Merged
mihaibudiu merged 7 commits into
mainfrom
cleanup
Nov 3, 2026
Merged

mihaibudiu merged 7 commits into
mainfrom
cleanup

Conversation

@mihaibudiu

Copy link
Copy Markdown
Contributor

There are 7 commits, each fixing a separate problem.
Some of them are from an earlier PR which is blocked on a Calcite issue.
None of these should change the semantics of SQL programs.
Some other are found as a result of a code audit, and are defensive changes.

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
…EATE INDEX

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
…rrors

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

What I ran

Check Result
./build.sh + mvn test -Dtest=BalancedJoinGCIncrementalTests,FloatingPointEqualityTests,NegativeParserTests,DocumentationTests,RegressionTests,Regression3Tests 228 run, 0 failures
Reverted the BalancedJoins and multi-row INSERT fixes, then reran the new tests both fail as expected (expected:<[false]> but was:<[true]>; Added zsets do not have the same type), so the tests catch the bugs
Extra QA, run as a scratch test and not committed: PK warning silenced by SET FELDERA_IGNORE_WARNING_FLOATING_POINT_EQUALITY; parse error inside a function body (position stripped, location still correct); INSERT mixing ROW(NULL), ROW(2) and a NULL row all pass
pre-commit run --files <changed> pass

Gates

  • missing (medium), commit quality: all 7 commits have a subject line only. The GC port-matching and balanced-join commits fix real miscompilation risks; each needs a body that explains the bug and why the fix is right.
  • missing (medium), tests: the CSE per-output GC change and the LowerAsof port filter have no tests (see inline comment).

The rest looks correct to me: the DISTINCT ON error is actionable and links to the docs, and the docs are updated.

@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 4dc3639 Nov 3, 2026
3 checks passed
@mihaibudiu
mihaibudiu deleted the cleanup branch November 3, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants