← 输入框|github.com|刷新
Skip to content

Add rclone to the build Dockerfile, too - #7804

Merged
llogiq merged 1 commit into
mainfrom
rclone-build
Nov 4, 2026
Merged

llogiq merged 1 commit into
mainfrom
rclone-build

Conversation

@llogiq

@llogiq llogiq commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

I want to use its S3 emulation for testing remote file sync, which is currently not possible, because the tests run in the build container which doesn't have rclone.

The docker installation is the same we already have in the deploy/Dockerfile.

I want to use its S3 emulation for testing remote file sync, which
is currently not possible, because the tests run in the build
container which doesn't have rclone.
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This is a build-image-only change. It adds the same pinned rclone 1.75.2 .deb install that deploy/Dockerfile already uses.

What I ran

Check Result
Downloaded the amd64 and arm64 .debs from downloads.rclone.org, ran sha256sum and compared against the pinned hashes ✅ both match
pre-commit run --files deploy/build.Dockerfile ✅ passed
Built the image ⏭️ not run, no docker in this environment

pitfall (medium): every CI workflow pins feldera-dev:sha-4c59cc4…. Merging this changes nothing for the tests until build-docker-dev publishes a new image and those pins are updated. The sync tests that depend on rclone need that follow-up bump, or they will fail with rclone: command not found, which is what this environment shows today.

@llogiq
llogiq added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 0a84627 Nov 4, 2026
3 checks passed
@llogiq
llogiq deleted the rclone-build branch November 4, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants