← 输入框|github.com|刷新
Skip to content

[SQL] Emit the type for each expression in the IR JSON - #7805

Merged
mihaibudiu merged 1 commit into
mainfrom
issue7803
Nov 4, 2026
Merged

mihaibudiu merged 1 commit into
mainfrom
issue7803

Conversation

@mihaibudiu

Copy link
Copy Markdown
Contributor

Fixes #7803

  • Unit tests added/updated- [ ] Integration tests added/updated

@mythical-fred-oss

Copy link
Copy Markdown
Contributor

What I ran (./build.sh, then mvn test -pl SQL-compiler):

Test Result
Gen2JsonTests 14/14 pass
OtherTests#serializationTest (JSON round-trip) pass
MetadataTests 87/87 pass
Gen2JsonTests with ir.aggregate added to isExpression pass

Correctness: I checked the writer and decoder. pop runs before postorder closes the object, so type stays inside the node. No ToJsonInnerVisitor postorder writes type any more, so no key appears twice. Every expression that visits its own type does it under the type property, which the hasType tracking relies on. The decoder skips types that are references or already cached. I found no bugs.

Gates: no gate fails. The change is covered by a unit test, I see nothing flaky, and the JSON IR is not a documented user surface.

missing (medium): test coverage is partial; see the inline comments.

Fixes #7803

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit c01891b Nov 4, 2026
1 check passed
@mihaibudiu
mihaibudiu deleted the issue7803 branch November 4, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SQL] IR JSON representation does not include types for some expressions

2 participants