Repository navigation
[connectors] Make the postgres runtime shutdown panic test robust on CI - #7808
Merged
Merged
Conversation
`a_panic_on_the_worker_task_still_shuts_the_runtime_down_in_time` gave the wrapper thread only 6s, and that time also paid for the panic hook, which resolves a full backtrace under `RUST_BACKTRACE=1`. Under CI load that took longer than 6s, so the test failed although the runtime shut down in time. - Raise the deliberate panic with `resume_unwind`, which skips the hook. - Keep the blocking task stuck until the test releases it, so that a regression hangs without end, and raise the timeout to 30s. - Panic only after the blocking task runs. Before, `yield_now` did not ensure this, and a queued task is dropped at shutdown, so the test could pass without testing the hang. Fixes #7716. Signed-off-by: Ben Pfaff <blp@feldera.com>
Contributor
|
LGTM.
|
bestouff
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7716.
a_panic_on_the_worker_task_still_shuts_the_runtime_down_in_timefailed intermittently in the merge queue on PRs unrelated to connectors.Cause
The test gave the wrapper thread 6s (
RUNTIME_SHUTDOWN_TIMEOUT+ 5s). The deliberatepanic!runs the panic hook before the unwind starts, and the Adapter Tests job setsRUST_BACKTRACE=1, so the hook resolves a full backtrace from the large debug test binary. Under CI load that, plusshutdown_timeout, could take more than 6s although the runtime shut down in time.Changes (test only)
resume_unwindin place ofpanic!sleep(30s)yield_nowdid not ensure this. A queued blocking task is dropped at shutdown, so the test could pass without testing the hangTesting
RUST_BACKTRACE=1shutdown_timeoutinblock_on_then_shut_downreplaced bydrop(runtime)cargo fmt --check