Repository navigation
[connectors] NATS: wait on the server for a library-recreated consumer. - #7824
Merged
Merged
Conversation
library_recreated_consumer_is_deleted_on_pause deletes the consumer from
the test, then uses WaitForConsumerCount to wait for the client library
to recreate it. WaitForConsumerCount polls the connector's own
created - deleted count. The connector does not count a delete from
outside or a recreate by the library, so that count stays at 1 and the
wait returns at once. The single server check after it then raced the
recreate, and lost on a loaded CI runner:
Connector's own count reached 1, but the server disagrees: found 0
consumers on stream 'str': []
Add WaitForServerConsumerCount, which polls the server's consumer list,
and use it for this wait.
Tested by delaying the library's recreate by 2 s in the test proxy: the
old wait fails with the error above and the new wait passes. The NATS
engine suite (70 cases) passes.
Closes #7820
Signed-off-by: Ben Pfaff <blp@feldera.com>
Contributor
|
LGTM. This is a test-only fix: the new wait polls the server's consumer list, which is the right source of truth after an external delete. The 50 ms poll has a deadline, so it is justified and does not add flakiness.
|
bestouff
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
library_recreated_consumer_is_deleted_on_pausetest.Cause
The test deletes the consumer itself, then uses
WaitForConsumerCountto wait for async-nats to recreate it.WaitForConsumerCountpolls the connector's owncreated - deletedcount:CreatePipeline,ExtendDeleteConsumers(by the test)WaitForConsumerCount{1}pollOn a loaded CI runner, the server check came first:
Fix
Add
WaitForServerConsumerCount, which polls the server's consumer list, and use it for this wait.WaitForConsumerCountstays the same where the connector makes every create and delete.Testing
Closes #7820