← 输入框|github.com|刷新
Skip to content

[ci] Give the iceberg-rest catalog one sqlite connection. - #7834

Merged
swanandx merged 1 commit into
mainfrom
issue7440
Nov 4, 2026
Merged

swanandx merged 1 commit into
mainfrom
issue7440

Conversation

@swanandx

@swanandx swanandx commented Nov 4, 2026

Copy link
Copy Markdown
Member

Linked Issue

Closes #7440. The test catalog keeps its tables in sqlite and uses two connections. Sometimes one connection finds the database locked by the other, and an iceberg follow test fails with HTTP 500.

before: 2 connections -> "database is locked" -> HTTP 500 -> test fails
after:  1 connection  -> requests wait their turn -> no lock errors

Describe Manual Test Plan

I ran the CI catalog image locally and sent it many requests at the same time. With two connections, 4 of 4 runs got the HTTP 500. With one connection, 8 of 8 runs had no errors, and the iceberg follow tests passed 60 of 60 times.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

None.

The catalog uses two sqlite connections by default. Sometimes one
finds the database locked by the other (SQLITE_BUSY), and the
follow tests get an HTTP 500.

Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. CI-only change. CATALOG_CLIENTS becomes the catalog property clients, which sets the JdbcClientPool size (the default is 2), so one connection does serialize sqlite access as the comment says. pre-commit run passes on the workflow file. The PR adds no test, which is fine for CI config, and the manual run (60/60 follow-test passes) is the right evidence for a flake fix.

@swanandx
swanandx requested a review from gz November 4, 2026 12:38
@swanandx
swanandx added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit ff09605 Nov 4, 2026
3 checks passed
@swanandx
swanandx deleted the issue7440 branch November 4, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapter/Runtime Integration Tests: network-timeout flakiness to GCS/S3/Iceberg-REST/Unity (not PR #7393's fault)

2 participants