← 输入框|github.com|刷新
Skip to content

[python] Use storage sizes the Hyperdisk minimum allows in test_deployment_resources - #7837

Merged
xiasongh merged 1 commit into
mainfrom
song/test-storage-hyperdisk-min
Nov 4, 2026
Merged

xiasongh merged 1 commit into
mainfrom
song/test-storage-hyperdisk-min

Conversation

@xiasongh

@xiasongh xiasongh commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hyperdisk Balanced volumes are at least 4 GiB, so the 1G volume in test_deployment_resources never provisions and the pipeline does not start. This failed the cloud merge queue (python-multihost arm64). The sizes now start at 4Gi, the Hyperdisk minimum. The refused shrink, 5000M against 5Gi, still mixes units.

@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This change only touches a test: it raises the storage sizes in test_deployment_resources above the 4 GiB Hyperdisk minimum.

  • What I ran: pre-commit run on the changed file, and ruff and ruff-format passed. I did not run the platform test, because it needs a pipeline-manager and a k8s cluster.
  • Checked: every size relationship still holds: grow 10G→20G is accepted, shrink to 15G is rejected, and a clear resets the size to 10G. Elsewhere in the file, the only size under 4 GiB is storage_min: "1G" in test_pipeline_restricted_runtime_config. No pipeline starts with that value, because the config is reset to {} right after, so it is fine.
  • missing (medium): the shrink check no longer mixes units (see inline comment).
  • No feldera-pr-checks gate fails.

@xiasongh
xiasongh marked this pull request as ready for review November 4, 2026 14:22
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This change only touches a test: it multiplies every storage size in test_deployment_resources by 10, and the relationships the test checks still hold:

  • grow 10G→20G is accepted
  • shrink to 15G is rejected
  • setting the unset storage_min is rejected
  • clearing storage resets to 10G
  • a resize to 30G survives a CPU edit

10G (about 9.3 GiB) is above the 4 GiB Hyperdisk Balanced minimum. Other small sizes in the suite (storage_min: 1G in test_runtime_config_edit_restricted, 2G in test_pipeline_configs.py) only go through PATCH and never start a pipeline with that volume, so they don't need the same fix.

Ran: pre-commit run --files python/tests/platform/test_pipeline_lifecycle.py (ruff and ruff-format pass). I couldn't run the test itself, because it needs a Kubernetes runner that can resize volumes; the CI merge queue will exercise it.

@xiasongh
xiasongh force-pushed the song/test-storage-hyperdisk-min branch from 68bc77d to 6f6ea40 Compare November 4, 2026 14:28
@xiasongh
xiasongh enabled auto-merge November 4, 2026 14:31
…yment_resources

Hyperdisk Balanced volumes are at least 4 GiB, so a 1G volume never
provisions and the pipeline does not start. The sizes now start at 4Gi.
@xiasongh
xiasongh force-pushed the song/test-storage-hyperdisk-min branch from 6f6ea40 to 8944cc9 Compare November 4, 2026 14:32
@xiasongh
xiasongh disabled auto-merge November 4, 2026 14:46
@xiasongh
xiasongh added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 99f259d Nov 4, 2026
1 check passed
@xiasongh
xiasongh deleted the song/test-storage-hyperdisk-min branch November 4, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants