Repository navigation
[web-console] Restore the checkbox check mark - #7839
Merged
Merged
Conversation
Commit 29dc418 deleted `checkbox-check.svg`, which the `.checkbox` class in `layout.css` uses as the check mark. Checked checkboxes showed no check mark. Restore the 2px stroke version from ab4215d. Rebuild the icon fonts with `bun run build-icons`. The generic font now contains the check mark. The material font drops three unused glyphs (heart-crack, film, package-open) whose source SVGs were removed earlier. Add a browser test that saves a screenshot of the checkbox and checks that the check mark image loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Contributor
|
LGTM. What I ran
No feldera-pr-checks gate fails: a test is included, I saw no flakiness (no sleeps, and the SVG is served by the local dev server), and there is no user-facing config or docs surface. |
mihaibudiu
approved these changes
Nov 4, 2026
Contributor
There was a problem hiding this comment.
not only you have 2 identical svg files, you are also replacing them with other identical svg files?
Contributor
Author
There was a problem hiding this comment.
The feldera-material-icons.svg is kind of a texturemap of a our proprietary icons, where each icon corresponds to a character, which is rendered by showing a small section of the shared atlas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this:

Restore the checkbox icon, deleted on accident, and re-generate code that references it.
Describe Manual Test Plan
svelte-check: 0 errors. Biome: no findings in the new spec.build-iconsends withbun run format, which fails onmainwith 37 pre-existing Biome errors. It also re-sorted imports in an unrelated file. That change is not included here.Checklist
Breaking Changes?
Describe Incompatible Changes
None.
🤖 Generated with Claude Code