← 输入框|github.com|刷新
Skip to content

[web-console] Restore the checkbox check mark - #7839

Merged
Karakatiza666 merged 1 commit into
mainfrom
checkbox-check-svg
Nov 5, 2026
Merged

Karakatiza666 merged 1 commit into
mainfrom
checkbox-check-svg

Conversation

@Karakatiza666

@Karakatiza666 Karakatiza666 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Fix this:
image

Restore the checkbox icon, deleted on accident, and re-generate code that references it.

Describe Manual Test Plan

  • Ran the new test without the SVG: it fails (image fetch not ok) and the screenshot shows an empty checked box. With the SVG: it passes and the screenshot shows the white check mark.
  • svelte-check: 0 errors. Biome: no findings in the new spec.
  • build-icons ends with bun run format, which fails on main with 37 pre-existing Biome errors. It also re-sorted imports in an unrelated file. That change is not included here.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

  • OpenAPI / REST HTTP API / feldera-types / manager
  • Feldera SQL (Syntax, Semantics)
  • feldera-sqllib
  • Python SDK
  • fda (CLI arguments)
  • Adapters (including configuration)
  • Storage Format / Checkpoints
  • Others (specify)

Describe Incompatible Changes

None.

🤖 Generated with Claude Code

Commit 29dc418 deleted `checkbox-check.svg`, which the `.checkbox`
class in `layout.css` uses as the check mark. Checked checkboxes showed
no check mark. Restore the 2px stroke version from ab4215d.

Rebuild the icon fonts with `bun run build-icons`. The generic font now
contains the check mark. The material font drops three unused glyphs
(heart-crack, film, package-open) whose source SVGs were removed earlier.

Add a browser test that saves a screenshot of the checkbox and checks
that the check mark image loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM.

What I ran

Check Result
bunx vitest --run --project client src/lib/checkbox.svelte.spec.ts ✅ pass (3 reruns, all stable)
Same test with checkbox-check.svg removed ❌ fails at response.ok, as expected: the test catches the regression
Screenshot __screenshots__/checkbox.png white check mark renders on the checked box; file is ignored via js-packages/.gitignore
pre-commit run --files <changed> ✅ pass
grep for heart-crack / film / package-open / hard-coded \\f1xx codepoints no users, so dropping the glyphs and renumbering codepoints is safe (CSS uses class names, and the font URL hash changed, which busts the cache)

No feldera-pr-checks gate fails: a test is included, I saw no flakiness (no sleeps, and the SVG is served by the local dev server), and there is no user-facing config or docs surface.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not only you have 2 identical svg files, you are also replacing them with other identical svg files?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feldera-material-icons.svg is kind of a texturemap of a our proprietary icons, where each icon corresponds to a character, which is rendered by showing a small section of the shared atlas.

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 3d4942b Nov 5, 2026
3 checks passed
@Karakatiza666
Karakatiza666 deleted the checkbox-check-svg branch November 5, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants