Repository navigation
[python] Remove redundant wait_for_idle calls from test_uda. - #7845
Merged
Merged
Conversation
`input_json` waits for its completion token before it returns, so the ad-hoc query that follows already sees the input. The other three `input_json` calls in this test already query without `wait_for_idle`. The flake in #7082 came from a completion token that completed one step early, fixed in a489b4b, not from `wait_for_idle`. Signed-off-by: Ben Pfaff <blp@feldera.com>
mihaibudiu
approved these changes
Nov 4, 2026
Contributor
|
LGTM.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_jsonwaits for its completion token before it returns, so the ad-hoc query that follows already sees the input. The other threeinput_jsoncalls intest_udaalready query withoutwait_for_idle.The flake in #7082 did not come from
wait_for_idle. A completion token could complete one step early, beforeupdate_snapshot()ran, so the ad-hoc query read the old, empty snapshot. a489b4b fixed that on 2026-10-09; the failure was on 2026-09-08.Closes #7082.