Repository navigation
[dbsp] Keep the circuit running after a failed checkpoint - #7846
Merged
Merged
Conversation
mihaibudiu
approved these changes
Nov 4, 2026
Contributor
|
LGTM. What I ran
Checked the core claim. Test gaps (medium):
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
Contributor
|
Verdict: infrastructure, not this PR. High confidence.
Next step: re-queueing should be fine — the same shared instance instability could recur, but there's nothing to fix in this PR. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
A worker error reply to any command made `DBSPHandle` kill the runtime, so a failed checkpoint stopped the pipeline. `PrepareCheckpoint` only takes in-memory snapshots of operator state, so a failure leaves the circuit consistent. Each command now says whether an error from it is fatal, and only `PrepareCheckpoint` is not. After a non-fatal error, `broadcast_command` still reads the replies of the other workers, so that no stale reply is left for the next command. The regression test for #7075 used a failed checkpoint to make the circuit thread kill the runtime. A failed checkpoint no longer does that, so this adds a test-only command, `InjectFatalError`, behind the new `testing` feature of `dbsp`, that every worker fails fatally. `Controller::inject_fatal_error` sends it from the circuit thread. The test, now `worker_error_does_not_deadlock`, checks that a failed checkpoint leaves the circuit running and that a fatal error does not deadlock. Fixes #7844. Signed-off-by: Ben Pfaff <blp@feldera.com>
blp
force-pushed
the
checkpoint-error-keeps-circuit
branch
from
November 5, 2026 21:05
c0e5749 to
3c6ce0a
Compare
blp
enabled auto-merge
November 5, 2026 21:05
blp
disabled auto-merge
November 5, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed checkpoint no longer kills the circuit.
PrepareCheckpointonly takes in-memory snapshots of operator state, so the circuit stays consistent after it fails. The controller already treats a checkpoint error as non-fatal and retries later.Closes #7844.
Describe Manual Test Plan
The new test
test_failed_checkpoint_keeps_circuitfails both with the old kill-on-error (Runtime(Terminated)) and with an early return that does not drain the other workers' replies (Expected CommitProgress response, got CheckpointPrepared([])).Checklist