← 输入框|github.com|刷新
Skip to content

Docs: phone menu back bar, option cards, square Previous / Next - #7850

Merged
Karakatiza666 merged 1 commit into
mainfrom
docs-menu-cards-pager
Nov 5, 2026
Merged

Karakatiza666 merged 1 commit into
mainfrom
docs-menu-cards-pager

Conversation

@tristencross

@tristencross tristencross commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This PR seeks to address some of the feedback from @Karakatiza666:

  • Phone menu: the "back to main men" bar is now in new brand colors that make the text readable
  • Updated the tiles on the /get-started docs page, so that they're more accurately in our brand guidelines (square corners, violet colors, subtle drop shadow effect, tighter more intentional spacing)
  • Previous and next buttons on entire docs site are now square corners

@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Review of a CSS-only docs change (docs.feldera.com/src/css/custom.css)

What I ran

  • pre-commit run --files docs.feldera.com/src/css/custom.css: passed.
  • I did not build the docs site. Instead, I checked the CSS by hand:
    • Braces are balanced.
    • Every variable the new rules use (--color-shell, --color-stone, --color-secondary-950, --color-violet, --text-base) is defined.
    • The new max-width: none rule has specificity (0,3,2), so it beats the 44rem rule .theme-doc-markdown > :not(.table-scroll-container) (0,2,0).
    • The unscoped .card .card__body rules only reach get-started/index.md and interface/index.mdx, so no other page is affected.
    • Dark mode is disabled, so there is no second theme to check.

Gates

Gate Status
Tests / flaky tests / SQL types / unsafe / deps / CI Not applicable (CSS only)
Manual testing described (hard rule 1), medium ❌ The PR description is empty. This is purely visual and has no tests, so please add before/after screenshots of the Get Started and Interface cards, the phone-menu back bar, and Previous / Next.
Commit message, low-medium The subject is about 90 characters, lowercase, and runs into the body with …. The body only finishes the subject and gives no why. Suggested subject: Restyle docs option cards, phone back bar and pagination. Add a short body that says why, for example that the back bar looked like the selected page.

The CSS itself looks good to me. Once there are screenshots and a cleaner commit message, this is LGTM.

@tristencross

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-11-04 at 7 07 33 PM

Base automatically changed from docs-looks to main November 5, 2026 05:49

@Karakatiza666 Karakatiza666 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit c9f6979 Nov 5, 2026
1 check passed
@Karakatiza666
Karakatiza666 deleted the docs-menu-cards-pager branch November 5, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants