Repository navigation
[python] Give the Delta snapshot tests' token waits the sinks' 60 s - #7852
Merged
Merged
Conversation
A completion token is complete only once every output connector has processed the resulting changes. In CI the Delta sinks of these tests write to an object store, so the two 30 s token waits also covered four Parquet writes and Delta log commits over the network, while the sink polls right next to them already allow 60 s. On a slow amd64 runner the token wait timed out after the pipeline had already taken 18 s to compile and 13 s to start. Fixes #7654.
Contributor
|
LGTM. This is a test-only change: it raises two completion-token waits from 30 s to 60 s, so they match the sink polls next to them that already allow 60 s.
|
swanandx
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7654.
A completion token is complete only once every output connector has processed the resulting changes (
crates/connectors/src/controller/stats.rs:110). In CI the Delta sinks oftest_output_snapshot.pywrite to an object store, so the two 30 s token waits also covered Parquet writes and Delta log commits over the network, while the sink polls right next to them already allow 60 s.push()helper intest_egress_send_snapshotinput_jsonintest_delta_output_send_snapshot_after_flag_flipIn the failing run the pipeline took 18 s to compile and 13 s to start before the token wait began, and the wait was still the only one in the file shorter than the work it measures.