Repository navigation
Fix: Directory in feldera-qa for QATests.java - #7853
Conversation
| List<File> result = new ArrayList<>(); | ||
| String dir = "../../../feldera-qa"; | ||
| String[] subdirs = new String[] { "new/workloads", "." }; | ||
| String[] subdirs = new String[] { "workloads" }; |
There was a problem hiding this comment.
pitfall (medium): If this path is wrong, nothing fails. When workloads/ is missing, getQATests() returns an empty list and qaTests passes in ~50 ms having compiled 0 files (I checked this locally). That is presumably how the old new/workloads path went stale without anyone noticing. Suggest making the test fail loudly, or at least report itself as skipped, when it finds no SQL files. For example, in qaTests():
List<File> tests = getQATests();
org.junit.Assume.assumeFalse("no QA workloads found under ../../../feldera-qa/workloads", tests.isEmpty());Assume reports a skip instead of a silent pass. Use Assert.assertFalse if a missing directory should count as a failure.
|
LGTM. This is a one-line, test-only path fix. It doesn't change product behaviour, and none of the PR-check gates apply (deps, unsafe code, docs, connectors, CI). What I ran (
Pitfall (medium): No CI workflow runs |
To be merged after https://github.com/feldera/feldera-qa/pull/472 is merged.