Repository navigation
Convert the last CRLF files to LF. - #7859
Merged
Merged
Conversation
These three files used CRLF line endings, and every other tracked file uses LF. This changes only the line endings: `git diff --ignore-cr-at-eol` shows no difference. The tutorial examples read `vaccinations.csv` with `csv::Reader`, which accepts both line endings. `tutorial1` prints the same 3961 records before and after. Signed-off-by: Ben Pfaff <blp@feldera.com>
mihaibudiu
approved these changes
Nov 5, 2026
Contributor
|
LGTM. Checked the merge commit:
No behaviour change, so no new tests are needed. |
blp
enabled auto-merge
November 5, 2026 18:33
blp
disabled auto-merge
November 5, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
None. Trivial change, found during review of #7858.
These three files used CRLF line endings, and every other tracked file uses LF:
python/feldera/rest/errors.pypython/feldera/rest/pipeline.pycrates/dbsp/examples/tutorial/vaccinations.csvThis changes only the line endings. To check:
git diff --ignore-cr-at-eolshows no difference.Describe Manual Test Plan
git diff --ignore-cr-at-eolis empty.ruff checkandruff format --checkpass on both files, and all oftests/unitpasses.dist/coord.rsread it withcsv::Reader, which accepts both line endings.cargo run -p dbsp --example tutorial1prints the same 3961 records with the CRLF file and with the LF file (cmpfinds no difference).Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
None.