← 输入框|github.com|刷新
Skip to content

Convert the last CRLF files to LF. - #7859

Merged
blp merged 1 commit into
mainfrom
python-lf-line-endings
Nov 5, 2026
Merged

blp merged 1 commit into
mainfrom
python-lf-line-endings

Conversation

@blp

@blp blp commented Nov 5, 2026

Copy link
Copy Markdown
Member

Linked Issue

None. Trivial change, found during review of #7858.

These three files used CRLF line endings, and every other tracked file uses LF:

File Lines
python/feldera/rest/errors.py 173
python/feldera/rest/pipeline.py 99
crates/dbsp/examples/tutorial/vaccinations.csv 3962

This changes only the line endings. To check: git diff --ignore-cr-at-eol shows no difference.

Describe Manual Test Plan

  • git diff --ignore-cr-at-eol is empty.
  • Python: ruff check and ruff format --check pass on both files, and all of tests/unit passes.
  • CSV: the tutorial examples and dist/coord.rs read it with csv::Reader, which accepts both line endings. cargo run -p dbsp --example tutorial1 prints the same 3961 records with the CRLF file and with the LF file (cmp finds no difference).

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

None.

These three files used CRLF line endings, and every other tracked file
uses LF. This changes only the line endings: `git diff
--ignore-cr-at-eol` shows no difference.

The tutorial examples read `vaccinations.csv` with `csv::Reader`, which
accepts both line endings. `tutorial1` prints the same 3961 records
before and after.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. Checked the merge commit:

  • git diff --ignore-cr-at-eol against the base is empty, so only line endings changed.
  • git grep -lI $'\r' finds no tracked files with CR left in them.
  • pre-commit run --files <3 files>: ruff, ruff-format and trailing-whitespace pass.
  • uv run --locked pytest tests/unit: 422 passed.
  • The CSV is read only by the dbsp tutorial and dist/coord.rs examples through csv::Reader, which accepts both line endings.

No behaviour change, so no new tests are needed.

@blp blp self-assigned this Nov 5, 2026
@blp
blp enabled auto-merge November 5, 2026 18:33
@blp blp added python Pull requests that update python code python-sdk Issues related to the feldera python sdk DBSP core Related to the core DBSP library rust Pull requests that update Rust code labels Nov 5, 2026
@blp
blp disabled auto-merge November 5, 2026 18:43
@blp
blp added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit e18b50b Nov 5, 2026
3 checks passed
@blp
blp deleted the python-lf-line-endings branch November 5, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DBSP core Related to the core DBSP library python Pull requests that update python code python-sdk Issues related to the feldera python sdk rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants