Repository navigation
[connectors] Report the error that stopped the circuit thread in /status - #7867
Merged
Merged
Conversation
mihaibudiu
approved these changes
Nov 5, 2026
Contributor
|
Review summary. No hard gate fails. The one finding is the misplaced doc comment noted inline. What I ran
What I checked
Missing (low): no test checks that |
| /// Records the reason before the state, so that an observer that sees | ||
| /// [PipelineState::Terminated] also sees why. | ||
| /// The error that stopped the circuit thread, if one did. | ||
| pub fn fatal_error(&self) -> Option<Arc<ControllerError>> { |
Contributor
There was a problem hiding this comment.
bug (medium, docs): These methods were inserted between set_suspended and its doc comment. Now pub fn fatal_error has a doc that starts "Terminates the pipeline because a suspend completed successfully…", and set_suspended has no doc. Please move the three /// lines above this one back above fn set_suspended.
Member
Author
…tus. When the circuit thread stopped with an error that the server does not classify as fatal, such as a fault-tolerance replay failure, /status reported only "Pipeline has been terminated." (PipelineTerminated). The cause was only in the log. The circuit thread now records the error before it terminates the pipeline, and /status reports that error with its own error code, for example ReplayFailure. Fixes #2986. Signed-off-by: Ben Pfaff <blp@feldera.com>
blp
force-pushed
the
ft-failure-fails-pipeline
branch
from
November 5, 2026 23:09
b843e3d to
82a00e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2986.
When the circuit thread stopped with an error that
is_fatal_controller_errordoes not classify as fatal, such as a fault-tolerance replay failure,/statusreported only "Pipeline has been terminated." (PipelineTerminated). The cause was only in the log. Commit 0b927cc already made the pipeline fail in this case; this change makes it fail with the correct error.controller/stats.rsGlobalControllerMetrics::fatal_error: the first error that stopped the circuit thread.controller.rsfinish()setsTerminated, so an observer that seesTerminatedalso sees the cause.server.rsterminated_statusreports the recorded error with its own error code. The error formatting moves intocontroller_error_status, which theFailedbranch also uses. This also corrects its log message, which namedSERVICE_UNAVAILABLEas the code it converted to.Tests
terminated_status_reports_the_fatal_error:/statusmapping.replay_failure_is_recorded_as_fatal_error: runs a fault-tolerant pipeline from a file, changes the file, restarts, and expects the pipeline to stop withReplayFailurerecorded.Both tests fail when the fix is disabled.