Repository navigation
[SQL] CSE improvements - #7892
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Fixes #7597 Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
What I ran: QA cases the PR's tests don't cover (all pass locally; worth adding):
@Test
public void testCSEBorrowAndValue() {
DBSPCompiler compiler = new DBSPCompiler(new CompilerOptions());
DBSPVariablePath t = b.refVar(b.tup(b.i32()));
DBSPExpression e = b.tuple(
b.call("f", b.call(b.str(), "h", b.field(t, 0)).borrow()),
b.call(b.str(), "h", b.field(t, 0)));
IDBSPInnerNode result = cse(compiler, e.closure(t));
assertCseVariables(compiler, result, 1);
Assert.assertEquals(1, countClones(compiler, result));
}Commit messages (medium): both commits are a subject line plus Otherwise LGTM: no feldera-pr-checks gate fails, and this is an internal compiler change that needs no docs or breaking-change handling. |
Linked Issue
Fixes #7597
Checklist