Repository navigation
[manager] Fix review nits from the prebuilt-binaries change - #7897
Merged
Merged
Conversation
The --prebuilt-binaries-directory help said that files are named by the source checksum. They are named by the prebuilt binary key, which does not depend on the pipeline, so the help now says that. The doc comment of binary_delivery_mode_from_config was attached to prebuilt_binary_key_depends_only_on_program. It is back on its test. toml is now a workspace dependency, like the other dependencies of pipeline-manager.
Contributor
|
LGTM. This PR only changes doc and help text and moves
I checked the new help text against |
swanandx
approved these changes
Nov 9, 2026
swanandx
left a comment
Member
There was a problem hiding this comment.
I don't have much context behind these nits, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7885.
--prebuilt-binaries-directoryhelp (crates/pipeline-manager/src/config.rs)crates/pipeline-manager/src/compiler/rust_compiler.rsbinary_delivery_mode_from_configtomldependencyCargo.toml),Cargo.lockunchangedTesting:
cargo test -p pipeline-manager --no-default-features --lib -- prebuilt binary_delivery: 5 passed.compiler-server --helptext.No behavior change.