← 输入框|github.com|刷新
Skip to content

[manager] Fix review nits from the prebuilt-binaries change - #7897

Merged
bestouff merged 1 commit into
mainfrom
manager-prebuilt-review-fixes
Nov 9, 2026
Merged

bestouff merged 1 commit into
mainfrom
manager-prebuilt-review-fixes

Conversation

@bestouff

@bestouff bestouff commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #7885.

Item Change
--prebuilt-binaries-directory help (crates/pipeline-manager/src/config.rs) Files are named by the prebuilt binary key, not the source checksum
Doc comment in crates/pipeline-manager/src/compiler/rust_compiler.rs "Tests the binary delivery mode configuration." moved back to binary_delivery_mode_from_config
toml dependency Now a workspace dependency (Cargo.toml), Cargo.lock unchanged

Testing:

  • cargo test -p pipeline-manager --no-default-features --lib -- prebuilt binary_delivery: 5 passed.
  • Checked the new compiler-server --help text.

No behavior change.

The --prebuilt-binaries-directory help said that files are named by
the source checksum. They are named by the prebuilt binary key, which
does not depend on the pipeline, so the help now says that.

The doc comment of binary_delivery_mode_from_config was attached to
prebuilt_binary_key_depends_only_on_program. It is back on its test.

toml is now a workspace dependency, like the other dependencies of
pipeline-manager.
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This PR only changes doc and help text and moves toml to a workspace dependency; runtime behaviour is unchanged.

Ran Result
cargo test --locked -p pipeline-manager --no-default-features --lib -- prebuilt binary_delivery 5 passed, Cargo.lock unchanged
pre-commit run --files <changed> clippy, fmt, machete, crypto-deps, OpenAPI, cargo doc passed; one default-features build hook could not finish because a network 504 interrupted the embedded-postgres download (not related to this PR)

I checked the new help text against prebuilt_binary_key, and it matches: the key ignores the pipeline ID. No new tests are needed because behaviour does not change.

@bestouff
bestouff requested review from gz and swanandx November 9, 2026 08:41

@swanandx swanandx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context behind these nits, but LGTM

@bestouff
bestouff added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit ca45ec3 Nov 9, 2026
3 checks passed
@bestouff
bestouff deleted the manager-prebuilt-review-fixes branch November 9, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants