Repository navigation
[qa] Prefix test pipeline names with run_ - #7899
Merged
Merged
Conversation
The relation names of the test start with the pipeline name, which starts with the first five characters of the commit SHA. A SHA that starts with a digit gives a view name that is not a valid Avro record name, so the pipeline fails to start. Fixes #7898 Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Contributor
|
LGTM. What I ran
Schema-subject cleanup reads the names from the generated SQL, so it picks up the new |
Fix #7898 for every test, not only the Kafka Avro test. unique_pipeline_name now starts every name with run_, so names that tests derive from it never start with a digit of the commit SHA. Revert the change local to the Kafka Avro test. The longer prefix pushes one test name over the length budget, so rename it. Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Karakatiza666
requested review from
jyotshnayaparla-00 and
tbfel
and removed request for
jyotshnayaparla-00 and
ryzhyk
November 9, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7898.
Problem
test_kafka_avro_variantsfails when the commit SHA starts with a digit (about 10 in 16 commits):unique_pipeline_namestarts every name with the first 5 characters ofGITHUB_SHA. Tests name SQL relations after the pipeline, and the Avro connector uses the view name as the Avro record name. Avro names must start with a letter or underscore.Fix
unique_pipeline_namenow prependsrun_, so every generated name starts with a letter:457ed_test_kafka_avro_1run_457ed_test_kafka_avro_1457ed_test_kafka_avro_1_viewrun_457ed_test_kafka_avro_1_viewThe commit SHA stays in the prefix, so
stop_ci_run_pipelines.pystill finds a run's pipelines by prefix (it builds the prefix withunique_pipeline_name("")).python/feldera/testutils.pyrun_prefixpython/tests/unit/test_pipeline_name_length.pyLONGEST_TAG_LENgrows by 4; new regression testpython/tests/platform/test_delta_input_change_feed.py..._reads_only_changesto..._skips_unchanged: with_autoit was 1 character over the new budgetpython/tests/stop_ci_run_pipelines.pyThe first commit fixed only the Kafka Avro test. The second commit replaces it with this fix for all tests, so the net diff does not touch
test_kafka_avro.py. Squash on merge.Testing
test_unique_pipeline_name_starts_with_a_lettersetsGITHUB_SHAto the SHA from the failing run. It fails before the fix and passes after it.pytest tests/unit/passes (429 tests). The static length check found the one overlong name above.Note for reviewers
The 4 extra characters reduce every test's name budget from 55 to 51. The static check covers names built from literals only. A name built at runtime that is now too long fails at pipeline creation with the clear assertion in
unique_pipeline_nameorvariant_pipeline_name.