← 输入框|github.com|刷新
Skip to content

[qa] Prefix test pipeline names with run_ - #7899

Merged
Karakatiza666 merged 2 commits into
mainfrom
fix-kafka-avro-digit-sha
Nov 9, 2026
Merged

Karakatiza666 merged 2 commits into
mainfrom
fix-kafka-avro-digit-sha

Conversation

@Karakatiza666

@Karakatiza666 Karakatiza666 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #7898.

Problem

test_kafka_avro_variants fails when the commit SHA starts with a digit (about 10 in 16 commits):

'457ed_test_kafka_avro_1_view' is not a valid Avro name: each dot-separated
segment must start with a letter or underscore ...

unique_pipeline_name starts every name with the first 5 characters of GITHUB_SHA. Tests name SQL relations after the pipeline, and the Avro connector uses the view name as the Avro record name. Avro names must start with a letter or underscore.

Fix

unique_pipeline_name now prepends run_, so every generated name starts with a letter:

Before After
Pipeline name 457ed_test_kafka_avro_1 run_457ed_test_kafka_avro_1
Avro view name 457ed_test_kafka_avro_1_view run_457ed_test_kafka_avro_1_view

The commit SHA stays in the prefix, so stop_ci_run_pipelines.py still finds a run's pipelines by prefix (it builds the prefix with unique_pipeline_name("")).

File Change
python/feldera/testutils.py Add the run_ prefix
python/tests/unit/test_pipeline_name_length.py LONGEST_TAG_LEN grows by 4; new regression test
python/tests/platform/test_delta_input_change_feed.py Rename ..._reads_only_changes to ..._skips_unchanged: with _auto it was 1 character over the new budget
python/tests/stop_ci_run_pipelines.py Help text

The first commit fixed only the Kafka Avro test. The second commit replaces it with this fix for all tests, so the net diff does not touch test_kafka_avro.py. Squash on merge.

Testing

  • New unit test test_unique_pipeline_name_starts_with_a_letter sets GITHUB_SHA to the SHA from the failing run. It fails before the fix and passes after it.
  • pytest tests/unit/ passes (429 tests). The static length check found the one overlong name above.
  • I did not run the integration tests locally. They need a Feldera instance, Kafka and a schema registry, so CI runs them.

Note for reviewers

The 4 extra characters reduce every test's name budget from 55 to 51. The static check covers names built from literals only. A name built at runtime that is now too long fails at pipeline creation with the clear assertion in unique_pipeline_name or variant_pipeline_name.

The relation names of the test start with the pipeline name, which starts
with the first five characters of the commit SHA. A SHA that starts with a
digit gives a view name that is not a valid Avro record name, so the
pipeline fails to start.

Fixes #7898

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
@Karakatiza666
Karakatiza666 requested a review from ryzhyk November 9, 2026 14:39
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM.

What I ran

Check Result
pre-commit run --files python/tests/workloads/test_kafka_avro.py pass (ruff, ruff-format)
Variant names for every TEST_CONFIGS entry, GITHUB_SHA=457ed…, FELDERA_TEST_TAG_SUFFIX set to "" and "m" all valid Avro names after the fix. Before the fix, table, view, index and loopback were all invalid.
pytest -k relation_names not run: importing the module hangs here without a reachable Feldera/Kafka. I checked the same logic with the imports stubbed out.

Schema-subject cleanup reads the names from the generated SQL, so it picks up the new r prefix. Topic names and the stale-topic sweep do not change.

Fix #7898 for every test, not only the Kafka Avro test. unique_pipeline_name
now starts every name with run_, so names that tests derive from it never
start with a digit of the commit SHA. Revert the change local to the Kafka
Avro test.

The longer prefix pushes one test name over the length budget, so rename it.

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
@Karakatiza666 Karakatiza666 changed the title [qa] Start the Kafka Avro test's relation names with a letter [qa] Prefix test pipeline names with run_ Nov 9, 2026
@Karakatiza666
Karakatiza666 requested review from jyotshnayaparla-00 and tbfel and removed request for jyotshnayaparla-00 and ryzhyk November 9, 2026 14:52

@ryzhyk ryzhyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 6b4162a Nov 9, 2026
1 check passed
@Karakatiza666
Karakatiza666 deleted the fix-kafka-avro-digit-sha branch November 9, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_kafka_avro_variants fails when CI pipeline name prefix (commit SHA) starts with a digit

2 participants