← 输入框|github.com|刷新
Skip to content

docs: Use codeartifact-token for private Cargo registries - #7901

Merged
xiasongh merged 1 commit into
mainfrom
song/codeartifact-token-docs
Nov 10, 2026
Merged

xiasongh merged 1 commit into
mainfrom
song/codeartifact-token-docs

Conversation

@xiasongh

@xiasongh xiasongh commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

The compiler server image no longer ships the AWS CLI (feldera/cloud#2176). Point the private Cargo registry docs at codeartifact-token and note the change in the changelog.

Merge after feldera/cloud#2176 is released.

@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This PR only changes docs.

Check Result
pre-commit run --files on both changed files passed
Changelog entry for the incompatible change, marked "Incompatible change (Enterprise)" present, matches the existing style
Links (/get-started/enterprise/private-cargo-registry) valid, page is in the sidebar
Tests, deps, unsafe, CI gates not applicable
  • pitfall (medium): see the inline comment. The docs site isn't versioned, so the new credential-provider example should say which release it needs.
  • The ordering is right: merge this only after the image change it describes is released, as the description already says.

@xiasongh
xiasongh marked this pull request as ready for review November 9, 2026 18:54
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This PR only changes docs. I ran pre-commit run on both changed files and it passed. The changelog entry covers the incompatible change, the old aws codeartifact get-authorization-token setup still has a migration path, and the commit message is fine. I couldn't check the codeartifact-token flags here because the image change isn't in this repo, so please hold the merge until the image ships, as the PR description says.

@xiasongh
xiasongh force-pushed the song/codeartifact-token-docs branch 2 times, most recently from f42cf4a to 9e35f33 Compare November 9, 2026 19:39
@xiasongh
xiasongh enabled auto-merge November 9, 2026 20:31
Comment thread docs.feldera.com/docs/changelog.md Resolved
@xiasongh
xiasongh disabled auto-merge November 9, 2026 20:32
@xiasongh
xiasongh added this pull request to the merge queue Nov 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 10, 2026
The compiler server image no longer ships the AWS CLI.

Signed-off-by: Song Huang <xiasongh@gmail.com>
@xiasongh
xiasongh force-pushed the song/codeartifact-token-docs branch from 9e35f33 to 31b6baa Compare November 10, 2026 01:45
@xiasongh
xiasongh added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit c178e1d Nov 10, 2026
1 check passed
@xiasongh
xiasongh deleted the song/codeartifact-token-docs branch November 10, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants