Repository navigation
[web-console] Don't autoexpand circuit diagram nodes on load - #7902
Merged
Merged
Conversation
Contributor
|
Review of PR #7902: don't auto-expand circuit diagram regions on load What I ran
Findings
Apart from the docs fix, the code change looks good. |
Karakatiza666
force-pushed
the
dont-autoexpand
branch
from
November 9, 2026 19:33
c5a9c7e to
239ff6d
Compare
mihaibudiu
approved these changes
Nov 9, 2026
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
These tests were making too many assumptions about the shape of the circuit shown. There should not be 9 test changes for a 1-line policy change.
Contributor
|
Fixes #7197 |
Contributor
Author
Well, if each test ensured a certain state of a node when initializing that would just be more complexity for the test setup. Hopefully this does not change often, so I think the initial state of a node is reasonable to rely on and just assume. |
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Karakatiza666
force-pushed
the
dont-autoexpand
branch
from
November 10, 2026 15:19
239ff6d to
93235a5
Compare
Karakatiza666
enabled auto-merge
November 10, 2026 15:23
Karakatiza666
disabled auto-merge
November 10, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the code that auto-expands the small circuit diagram regions. Multiple tests needed an update - they were dependent on whether or not the nodes are expanded after loading.
Describe Manual Test Plan
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes