Repository navigation
[web-console] Set the browser tab title on every page - #7914
Merged
Merged
Conversation
Fixes #5805. Svelte sets `document.title` when a page mounts, but does not restore it when the page unmounts. Most pages had no `<title>`, so the tab kept the title of an earlier page. For example, after the profile viewer of one pipeline, the page of another pipeline showed the name of the first pipeline. Each page now sets its own title, `<page> | Feldera`, and the pipeline page shows the name of the pipeline. The admin and profile viewer titles use `|` as the separator too.
Contributor
|
LGTM. Ran
Every |
mihaibudiu
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5805.
Cause
Svelte 5 sets
document.titlefrom<svelte:head><title>when a page mounts. It does not restore the title when the page unmounts. Only the admin and profile viewer pages had a<title>. So after you open the profile viewer ofnb-unihost-2and go to the page ofnb-blp, the tab still showsnb-unihost-2 | Profile Viewer.Fix
Each page now sets its own title. The separator is now
|(it was an em-dash).<pipeline name> | FelderaFelderaDemos | FelderaHealth | FelderaAdministration | FelderaSelect tenant | FelderaError | Feldera<pipeline name> | Profile ViewerorProfile ViewerTests
All 13 title tests fail when the
<title>blocks are removed.