Repository navigation
[connectors] Make DynamoDB test failures show their cause - #7917
Merged
Merged
Conversation
dynamodb_conditional_put_skips_existing_row found 1 row where it expected 2 in a merge queue run, and the log did not show why. The endpoint of the test has no controller, so a failed write was reported nowhere, and the test had no logger for the retry warnings. - Scan with consistent_read. A default scan is eventually consistent, also on DynamoDB Local. - Assert that the connector dropped no item before the conditional tests read the table. - Start the test logger in every test that uses the service. - Pin the DynamoDB Local image of the adapter tests to 3.3.2. Refs #7908 Signed-off-by: Xavier Bestel <xavier.bestel@feldera.com>
Contributor
|
LGTM. What I ran
Only test code and CI change, so no gates apply. |
mihaibudiu
approved these changes
Nov 10, 2026
| fn assert_no_failed_items(metrics: &DynamoDBOutputMetrics) { | ||
| assert_eq!( | ||
| dynamodb_metric(metrics, "dynamodb_output_failed_items_total"), | ||
| 0.0, |
blp
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Refs #7908. This PR does not close the issue: the cause of the failure is not known. The PR makes the next occurrence show it.
What changed
dynamodb_conditional_put_skips_existing_rowfound 1 row where it expected 2 in a merge queue run. The log had only the row count.scan_tableusesconsistent_read(true)dynamodb_output_failed_items_total == 0before they read the tablebatch_endreports a failed write nowhere. A dropped write looked like a wrong row count.wait_for_dynamodbstarts the test loggeramazon/dynamodb-localis pinned to3.3.2with its digestlatestcan change the emulator between runs.3.3.2is the version of the failed run.Only test code and the CI workflow change.
Describe Manual Test Plan
connector_suitesagainst the pinned image: 49 passed.dynamodb_conditional_put_skips_existing_rowfail with an invalid condition expression. The test then failed on the new assertion, and the output had the connector warning with the DynamoDB error. Reverted that change.Checklist
Breaking Changes?
None.