Repository navigation
[qa] Check new_pipeline_with_suffix names against the pipeline name limit - #7921
Merged
Merged
Conversation
…imit The run_ prefix pushed test_bucket_owner_lock_rejects_other_pipeline_intruder to 64-65 chars, over the 62-char limit, so the test fails at pipeline creation. The name-length guard missed it because it only measured tests taking a pipeline_name argument, not the <test>_<suffix> names that SharedTestPipeline.new_pipeline_with_suffix builds. Measure those suffixed names too, and shorten the offending test name.
Karakatiza666
self-requested a review
November 11, 2026 14:43
Karakatiza666
approved these changes
Nov 11, 2026
Karakatiza666
left a comment
Contributor
There was a problem hiding this comment.
A more complete checker, good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_bucket_owner_lock_rejects_other_pipelinecreates<test>_intruder. With therun_prefix that name is 64 chars (65 in multihost), over the 62-char limit, so the test fails at pipeline creation.tests/unit/test_pipeline_name_length.pymissed it: it only measures tests that take apipeline_nameargument. It skips the<test>_<suffix>names thatSharedTestPipeline.new_pipeline_with_suffix(...)builds.Changes
tests/unit/test_pipeline_name_length.py<test>_<suffix>for every literalnew_pipeline_with_suffix("…")calltests/platform/test_checkpoint_sync.pytest_bucket_owner_lock_rejects_other(_intrudervariant: 45 chars, budget 51)Testing
'test_bucket_owner_lock_rejects_other_pipeline_intruder' is 54 chars, 3 overuv run pytest tests/unit/test_pipeline_name_length.py, 4 passedpre-commit(ruff, ruff-format) passes