← 输入框|github.com|刷新
Skip to content

[qa] Check new_pipeline_with_suffix names against the pipeline name limit - #7921

Merged
Karakatiza666 merged 1 commit into
mainfrom
fred/pipeline-suffix-name-length
Nov 11, 2026
Merged

Karakatiza666 merged 1 commit into
mainfrom
fred/pipeline-suffix-name-length

Conversation

@mythical-fred-ops

Copy link
Copy Markdown
Contributor

Problem

test_bucket_owner_lock_rejects_other_pipeline creates <test>_intruder. With the run_ prefix that name is 64 chars (65 in multihost), over the 62-char limit, so the test fails at pipeline creation.

tests/unit/test_pipeline_name_length.py missed it: it only measures tests that take a pipeline_name argument. It skips the <test>_<suffix> names that SharedTestPipeline.new_pipeline_with_suffix(...) builds.

Changes

File Change
tests/unit/test_pipeline_name_length.py Also measure <test>_<suffix> for every literal new_pipeline_with_suffix("…") call
tests/platform/test_checkpoint_sync.py Rename to test_bucket_owner_lock_rejects_other (_intruder variant: 45 chars, budget 51)

Testing

  • Guard fails before the rename: 'test_bucket_owner_lock_rejects_other_pipeline_intruder' is 54 chars, 3 over
  • Guard passes after the rename: uv run pytest tests/unit/test_pipeline_name_length.py, 4 passed
  • pre-commit (ruff, ruff-format) passes

…imit

The run_ prefix pushed test_bucket_owner_lock_rejects_other_pipeline_intruder
to 64-65 chars, over the 62-char limit, so the test fails at pipeline
creation. The name-length guard missed it because it only measured tests
taking a pipeline_name argument, not the <test>_<suffix> names that
SharedTestPipeline.new_pipeline_with_suffix builds.

Measure those suffixed names too, and shorten the offending test name.
@Karakatiza666
Karakatiza666 self-requested a review November 11, 2026 14:43

@Karakatiza666 Karakatiza666 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more complete checker, good

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit b8d42fc Nov 11, 2026
3 checks passed
@Karakatiza666
Karakatiza666 deleted the fred/pipeline-suffix-name-length branch November 11, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant