Repository navigation
[SQL] Improve Simplify for casts - #7929
Merged
Merged
Conversation
Contributor
|
LGTM. The fix covers #7925: Simplify no longer puts a SQL cast on a literal that only gains nullability (unary, binary, What I ran
Gates: tests added, no docs needed (bug fix), no deps or unsafe code, no flaky patterns. missing (medium): The regression test only covers BOOLEAN. pitfall (medium): See the inline comment. Non-literal nullability-only results still get a |
mihaibudiu
force-pushed
the
issue7925
branch
from
November 10, 2026 22:08
2153587 to
ba793eb
Compare
anandbraman
approved these changes
Nov 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 11, 2026
Fixes #7925 Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue7925
branch
from
November 11, 2026 03:32
ba793eb to
db29185
Compare
mihaibudiu
enabled auto-merge
November 11, 2026 03:32
mihaibudiu
disabled auto-merge
November 11, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #7925
Improved simplification code
Checklist