Repository navigation
[web-console] Fix duplicate key crash in the admin page owner lists - #7939
Merged
Merged
Conversation
Contributor
|
LGTM
feldera-pr-checks gates: test added for the changed behaviour, the test isn't flaky (it uses |
Deploy-time config can list the same owner or owner trust more than once, and trusts that differ only by audience are valid. The keyed lists used `issuer + subject` as the trust key, so such config crashed the page with each_key_duplicate. Drop repeated entries and include the audience in the trust key. Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Karakatiza666
force-pushed
the
fix-admin-owner-duplicates
branch
from
November 11, 2026 11:33
98cc216 to
33fb2d7
Compare
mihaibudiu
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Platform owners" section of the admin page crashed with
each_key_duplicateon a deployment that has two owner trusts with the same issuer and subject. They differ only in audience values, and both are intended.The owner and owner trust lists come from deploy-time config (
--owners,--owner-trusts). The manager returns them as-is, without a duplicate check. The page keyed them as follows:ownerissuer + subjectThe page now drops repeated entries before it renders the lists. The trust key is
JSON.stringify([issuer, subject, audience]), so trusts that differ only by audience each get their own row.Testing
A new test in
AdminPage.svelte.spec.tsmounts the page with a repeated owner, two trusts that differ only by audience, and an exact repeat of one of those trusts. It checks that each distinct entry shows once.each_key_duplicate.issuer + subjectkey put back, it also fails, so the test covers the audience case by itself.