Repository navigation
[SQL] Remove unused recursive circuits - #7954
Conversation
|
LGTM. The fix is correct. FindDeadCode keeps a nested operator only when one of its outputs is reachable, so it is safe to drop the whole circuit in RemoveOperators. The What I ran
missing (medium): the issue's actual repro is not tested. + @Test
+ public void issue7946LeftJoinEmpty() {
+ String sql = """
+ CREATE TABLE t(src BIGINT, dst BIGINT);
+ DECLARE RECURSIVE VIEW p1(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p1 AS SELECT src, dst FROM t UNION SELECT p1.src, t.dst FROM p1 JOIN t ON t.src = p1.dst;
+ DECLARE RECURSIVE VIEW p2(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p2 AS SELECT src, dst FROM t UNION SELECT p2.src, t.dst FROM p2 JOIN t ON t.src = p2.dst;
+ CREATE LOCAL VIEW empty_left AS
+ SELECT CAST(NULL AS BIGINT) AS id FROM (VALUES (1)) AS one(x) WHERE FALSE;
+ CREATE MATERIALIZED VIEW o AS
+ SELECT l.id, r.dst FROM empty_left AS l LEFT JOIN p1 AS r ON l.id = r.src
+ UNION ALL
+ SELECT l.id, r.dst FROM empty_left AS l LEFT JOIN p2 AS r ON l.id = r.src
+ UNION ALL
+ SELECT src, dst FROM t;""";
+ var ccs = this.getCCS(sql);
+ ccs.visit(new CircuitVisitor(ccs.compiler) {
+ @Override
+ public void postorder(DBSPNestedOperator operator) {
+ Assert.fail("Unexpected recursive circuit " + operator);
+ }
+ });
+ ccs.step("INSERT INTO t VALUES(1, 2);", """
+ id | dst | weight
+ ------------------
+ 1 | 2 | 1""");
+ }bug (medium), not caused by this PR: a related DeadCode crash. It happens when the second view in a mutual recursion is CREATE TABLE t(src BIGINT, dst BIGINT);
DECLARE RECURSIVE VIEW a(src BIGINT, dst BIGINT);
DECLARE RECURSIVE VIEW b(src BIGINT, dst BIGINT);
CREATE LOCAL VIEW a AS SELECT src, dst FROM t UNION SELECT b.src, t.dst FROM b JOIN t ON t.src = b.dst;
CREATE LOCAL VIEW b AS SELECT src, dst FROM a;
CREATE MATERIALIZED VIEW o AS SELECT * FROM a; |
anandbraman
left a comment
There was a problem hiding this comment.
test looks good. Thanks!
|
Review: LGTM. The fix matches the root cause in #7946: What I ran
Missing (medium): the test does not cover the issue's original repro. Test diffdiff --git a/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/recursive/RecursiveTests.java b/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/recursive/RecursiveTests.java
index b8a5763..fa0a714 100644
--- a/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/recursive/RecursiveTests.java
+++ b/sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/recursive/RecursiveTests.java
@@ -534,6 +534,63 @@ public class RecursiveTests extends BaseSQLTests {
cc.visit(visitor);
}
+ @Test
+ public void issue7946LeftJoinEmpty() {
+ // p1 and p2 are read, but only through a LEFT JOIN with an always-empty left side
+ String sql = """
+ CREATE TABLE t(src BIGINT, dst BIGINT);
+ DECLARE RECURSIVE VIEW p1(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p1 AS SELECT src, dst FROM t UNION SELECT p1.src, t.dst FROM p1 JOIN t ON t.src = p1.dst;
+ DECLARE RECURSIVE VIEW p2(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p2 AS SELECT src, dst FROM t UNION SELECT p2.src, t.dst FROM p2 JOIN t ON t.src = p2.dst;
+ CREATE LOCAL VIEW empty_left AS
+ SELECT CAST(NULL AS BIGINT) AS id FROM (VALUES (1)) AS one(x) WHERE FALSE;
+ CREATE MATERIALIZED VIEW o AS
+ SELECT l.id, r.dst FROM empty_left AS l LEFT JOIN p1 AS r ON l.id = r.src
+ UNION ALL
+ SELECT l.id, r.dst FROM empty_left AS l LEFT JOIN p2 AS r ON l.id = r.src
+ UNION ALL
+ SELECT src, dst FROM t;""";
+ var ccs = this.getCCS(sql);
+ ccs.visit(new CircuitVisitor(ccs.compiler) {
+ @Override
+ public void postorder(DBSPNestedOperator operator) {
+ Assert.fail("Unexpected recursive circuit " + operator);
+ }
+ });
+ ccs.stepWeightOne("INSERT INTO t VALUES(1, 2);", """
+ id | dst
+ ----------
+ 1 | 2""");
+ }
+
+ @Test
+ public void issue7946OneDeadOneLive() {
+ // p1 is dead, p2 is used: only p2's circuit must survive
+ String sql = """
+ CREATE TABLE t(src BIGINT, dst BIGINT);
+ DECLARE RECURSIVE VIEW p1(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p1 AS SELECT src, dst FROM t UNION SELECT p1.src, t.dst FROM p1 JOIN t ON t.src = p1.dst;
+ DECLARE RECURSIVE VIEW p2(src BIGINT, dst BIGINT);
+ CREATE LOCAL VIEW p2 AS SELECT src, dst FROM t UNION SELECT p2.src, t.dst FROM p2 JOIN t ON t.src = p2.dst;
+ CREATE VIEW o AS SELECT * FROM p2;""";
+ var ccs = this.getCCS(sql);
+ int[] count = new int[1];
+ ccs.visit(new CircuitVisitor(ccs.compiler) {
+ @Override
+ public void postorder(DBSPNestedOperator operator) {
+ count[0]++;
+ }
+ });
+ Assert.assertEquals(1, count[0]);
+ ccs.stepWeightOne("INSERT INTO t VALUES(1, 2), (2, 3);", """
+ src | dst
+ ----------
+ 1 | 2
+ 2 | 3
+ 1 | 3""");
+ }
+
@Test
public void testRecursive2() {
// Non-incremental test |
Fixes #7946. Also, CSE merges the outputs of a recursive circuit that map to the same stream. Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
b5f173e to
336e9dc
Compare
Fixes #7946.