← 输入框|github.com|刷新
Skip to content

[python] Fix test_pipeline_deployment on GKE and multihost - #7968

Merged
xiasongh merged 1 commit into
mainfrom
song/deployment-test-storage-4gi
Nov 13, 2026
Merged

xiasongh merged 1 commit into
mainfrom
song/deployment-test-storage-4gi

Conversation

@xiasongh

Copy link
Copy Markdown
Contributor

Fixes the test added in #7490. It blocks feldera/cloud#2088 in the cloud merge queue.

Problem Fix
GKE hyperdisk-balanced refuses volumes under 4 GiB. With storage_max: 1G the PVC never binds, and provisioning times out after 1200 s. storage_max: 4Gi, as test_deployment_resources uses.
PATCH replaces the whole runtime_config, so multihost drops hosts: 2. Read the current runtime_config and change only resources.

GKE hyperdisk-balanced refuses volumes under 4 GiB, so storage_max is
now 4Gi. PATCH replaces the whole runtime_config, so the test now keeps
hosts and workers.
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. This changes only a test, and it now does the same thing as test_deployment_resources: it reads the full runtime_config and uses storage_max: "4Gi".

  • Ran: pre-commit run on the changed file: ruff and ruff-format pass. I did not run the platform test here because it needs a running pipeline-manager.
  • Checked: with the change, hosts, workers and logging from create_pipeline are kept through the PATCH. The 4Gi spelling is stored and returned unchanged (test_deployment_resources already asserts this for 5Gi), so the check that the spec matches RESOURCES still holds.
  • Gates: this changes no product behaviour, so it needs no docs and raises no breaking-change concern. It adds no sleeps or timing dependence, so no new flakiness risk.

@xiasongh
xiasongh marked this pull request as ready for review November 13, 2026 01:57
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM. Test-only fix: 4Gi meets the GKE hyperdisk minimum, and reading the current runtime_config before the PATCH keeps hosts and workers. Both follow the pattern test_deployment_resources already uses. pre-commit (ruff, ruff-format) passes on the changed file. I couldn't run the platform test here because it needs a running pipeline-manager and Kubernetes runner.

@xiasongh
xiasongh added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit ebc97e5 Nov 13, 2026
5 checks passed
@xiasongh
xiasongh deleted the song/deployment-test-storage-4gi branch November 13, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants