Repository navigation
[python] Fix test_pipeline_deployment on GKE and multihost - #7968
Merged
Merged
Conversation
GKE hyperdisk-balanced refuses volumes under 4 GiB, so storage_max is now 4Gi. PATCH replaces the whole runtime_config, so the test now keeps hosts and workers.
Contributor
|
LGTM. This changes only a test, and it now does the same thing as
|
xiasongh
marked this pull request as ready for review
November 13, 2026 01:57
lalithsuresh
approved these changes
Nov 13, 2026
Contributor
|
LGTM. Test-only fix: 4Gi meets the GKE hyperdisk minimum, and reading the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test added in #7490. It blocks feldera/cloud#2088 in the cloud merge queue.
hyperdisk-balancedrefuses volumes under 4 GiB. Withstorage_max: 1Gthe PVC never binds, and provisioning times out after 1200 s.storage_max: 4Gi, astest_deployment_resourcesuses.runtime_config, so multihost dropshosts: 2.runtime_configand change onlyresources.