← 输入框|github.com|刷新
Skip to content

[python] Accept generic wording in checkpoint bucket ownership tests - #7975

Open
mythical-fred-ops[bot] wants to merge 1 commit into
mainfrom
fred/checkpoint-bucket-owner-regex
Open

mythical-fred-ops[bot] wants to merge 1 commit into
mainfrom
fred/checkpoint-bucket-owner-regex

Conversation

@mythical-fred-ops

Copy link
Copy Markdown
Contributor

The checkpoint bucket-ownership error is not specific to S3, so its message may begin with Checkpoint bucket is already owned by instead of S3 checkpoint bucket is already owned by.

Change

  • python/tests/platform/test_checkpoint_sync.py: test_bucket_owner_lock_rejects_other and test_take_bucket_ownership_at_startup_only now match [Cc]heckpoint bucket is already owned by ..., which accepts both wordings.

Validation

  • pre-commit (ruff, ruff-format) passes.
  • Checked the new regex with re.search against both message forms; both match.
  • I did not run the platform tests, because they need a live deployment with object storage.

The bucket-ownership error is not specific to S3, so its message may say
"Checkpoint bucket is already owned by ..." instead of "S3 checkpoint
bucket is already owned by ...". Match either form so the tests do not
depend on which object store the message names.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants