← 输入框|github.com|刷新
Skip to content

[manager] Do not relay an upstream Content-Length in streaming_proxy() - #7984

Merged
blp merged 1 commit into
mainfrom
proxy-drop-content-length
Nov 15, 2026
Merged

blp merged 1 commit into
mainfrom
proxy-drop-content-length

Conversation

@blp

@blp blp commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

From actix-web 4.12, HttpResponseBuilder::streaming() sends a sized body, not a chunked stream, if the response already has a Content-Length. streaming_proxy() copied every upstream header, so a multihost pipeline's circuit profile, which the coordinator sends with a length, came back sized. This made test_circuit_profile_streaming fail on multihost pipelines.

Now streaming_proxy() drops the upstream Content-Length, as the buffered proxy path already does.

Fixes feldera/cloud#2230. The same failure blocks feldera/cloud#2177 in the merge queue.

Testing

Run Result
cargo test -p pipeline-manager --lib streaming_proxy 5 passed
Same, with the filter taken out new test test_streaming_proxy_drops_upstream_content_length fails (content-length present)

…xy()`.

From actix-web 4.12, `HttpResponseBuilder::streaming()` sends a sized
body, not a chunked stream, if the response already has a
`Content-Length`.
`streaming_proxy()` copied every upstream header, so a multihost
pipeline's circuit profile, which the coordinator sends with a length,
came back sized.  This made `test_circuit_profile_streaming` fail on
multihost pipelines (feldera/cloud#2230).

Now `streaming_proxy()` drops the upstream `Content-Length`, as the
buffered proxy path already does.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@blp blp added bug Something isn't working Pipeline manager Pipeline manager (API, API server, runner, compiler server) multihost Related to multihost or distributed pipelines labels Nov 15, 2026
@blp blp self-assigned this Nov 15, 2026
@blp blp changed the title [pipeline-manager] Stream a proxied body chunked when the pipeline sizes it [manager] Do not relay an upstream Content-Length in streaming_proxy() Nov 15, 2026
@blp
blp requested review from gz, mihaibudiu and ryzhyk November 15, 2026 16:36
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM.

Check Result
cargo test --locked -p pipeline-manager --lib streaming_proxy 5 passed
Same test with the filter reverted test_streaming_proxy_drops_upstream_content_length fails at the content-length assert, so the test catches the regression
pre-commit run --files interaction.rs passed

The fix matches what the buffered proxy path already does (it drops content-length too). No feldera-pr-checks gate fails.

@blp
blp added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit a5dbb88 Nov 15, 2026
3 checks passed
@blp
blp deleted the proxy-drop-content-length branch November 15, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working multihost Related to multihost or distributed pipelines Pipeline manager Pipeline manager (API, API server, runner, compiler server)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants