Repository navigation
[manager] Do not relay an upstream Content-Length in streaming_proxy() - #7984
Merged
Merged
Conversation
…xy()`. From actix-web 4.12, `HttpResponseBuilder::streaming()` sends a sized body, not a chunked stream, if the response already has a `Content-Length`. `streaming_proxy()` copied every upstream header, so a multihost pipeline's circuit profile, which the coordinator sends with a length, came back sized. This made `test_circuit_profile_streaming` fail on multihost pipelines (feldera/cloud#2230). Now `streaming_proxy()` drops the upstream `Content-Length`, as the buffered proxy path already does. Signed-off-by: Ben Pfaff <blp@feldera.com>
Content-Length in streaming_proxy()
Contributor
|
LGTM.
The fix matches what the buffered proxy path already does (it drops |
gz
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From actix-web 4.12,
HttpResponseBuilder::streaming()sends a sized body, not a chunked stream, if the response already has aContent-Length.streaming_proxy()copied every upstream header, so a multihost pipeline's circuit profile, which the coordinator sends with a length, came back sized. This madetest_circuit_profile_streamingfail on multihost pipelines.Now
streaming_proxy()drops the upstreamContent-Length, as the buffered proxy path already does.Fixes feldera/cloud#2230. The same failure blocks feldera/cloud#2177 in the merge queue.
Testing
cargo test -p pipeline-manager --lib streaming_proxytest_streaming_proxy_drops_upstream_content_lengthfails (content-lengthpresent)