Repository navigation
[pipeline-manager] Collect support data for due pipelines concurrently - #8007
Draft
pavanmanishd wants to merge 1 commit into
Draft
pavanmanishd wants to merge 1 commit into
pavanmanishd wants to merge 1 commit into
Conversation
The background support data collector collected the due pipelines one at a time. Thus a slow pipeline delayed the collection of all other due pipelines. Collect up to 4 due pipelines at the same time. Schedule the next collection of each pipeline from the time its own collection completes. Fixes feldera#7933. Signed-off-by: pavanmanishd <pavanmanishd@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7933. Design: #7933 (comment)
This is a draft. I will mark it ready for review after a maintainer accepts the design in #7933.
The background support data collector collected the due pipelines one at a time. Thus a slow pipeline delayed the collection of all other due pipelines.
Changes:
collect_due_pipelinescollects up to 4 due pipelines at the same time withbuffer_unordered.Each collection keeps its bundle in memory until it is stored. Thus
MAX_CONCURRENT_COLLECTIONSalso limits the memory of the manager. I chose 4. Tell me if you prefer a different value.Test:
slow_pipeline_does_not_delay_other_collections. One pipeline answers each request after 2 s. The other pipeline answers at once. The slow pipeline is first in the schedule. The test checks that the data of the fast pipeline is stored in less than 2 s. Before the change, the data was stored after 6.04 s. After the change, it is stored after about 60 ms.