← 输入框|github.com|刷新
Skip to content

[python] Declare binary test columns that fit their values - #8009

Merged
ryzhyk merged 1 commit into
mainfrom
fix-asof-tests-binary-length
Nov 19, 2026
Merged

ryzhyk merged 1 commit into
mainfrom
fix-asof-tests-binary-length

Conversation

@ryzhyk

@ryzhyk ryzhyk commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Two aggtest tables declare bin BINARY, which SQL reads as BINARY(1), yet insert longer values: three bytes in every row of the ASOF tests' tables, and three bytes and a 27-byte gzip blob in the illegal-argument tests' table. The engine keeps such values whole, so the tests pass, but their input does not fit their schema, and a pipeline that checks the declared width on input refuses these rows.

The columns now take the type of the values the tests insert:

  • The ASOF tables declare bin BINARY(3), the width of every value they hold.
  • The illegal-argument table declares bin VARBINARY, since its values differ in length.

The expected outputs stay as they are.

Linked Issue

Describe Manual Test Plan

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

Two aggtest tables declare `bin BINARY`, which SQL reads as BINARY(1),
yet insert longer values: three bytes in every row of the ASOF tests'
tables, and three bytes and a 27-byte gzip blob in the
illegal-argument tests' table. The static engine keeps such values
whole, so the tests pass, but their input does not fit their schema,
and a pipeline that checks the declared width on input refuses these
rows.

The columns now take the type of the values the tests insert:

- The ASOF tables declare `bin BINARY(3)`, the width of every value
  they hold.
- The illegal-argument table declares `bin VARBINARY`, since its
  values differ in length.

The expected outputs stay as they are.

Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
@ryzhyk
ryzhyk requested a review from mihaibudiu November 18, 2026 21:21
@ryzhyk ryzhyk added the QA Testing and quality assurance label Nov 18, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM — only test schemas change, and every bin BINARY column that held more than one byte is now fixed (I grepped python/tests and found no others).

What I ran

Check Result
./build.sh + sql2dbsp on every table and view in asof_tests (except those expected to fail), new schema ✅ compiles
Same for illarg_tests (cast, cmp_operators, str_bin_type_fn, agg, arr_map, str_unicode) with bin VARBINARY ✅ compiles, including bin || bin, CONCAT, SUBSTRING, OVERLAY, and the CAST/SAFE_CAST to UUID views
pre-commit run --files <changed> ✅ passed
Runtime aggtests against a pipeline-manager ⏭️ not run (no manager in this environment), so I could not confirm that the expected outputs are unchanged

No gates fail. This is a test-only change, so no new tests or docs are needed.

@ryzhyk
ryzhyk added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 53866b9 Nov 19, 2026
3 checks passed
@ryzhyk
ryzhyk deleted the fix-asof-tests-binary-length branch November 19, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Testing and quality assurance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants