Repository navigation
[python] Declare binary test columns that fit their values - #8009
Merged
Merged
Conversation
Two aggtest tables declare `bin BINARY`, which SQL reads as BINARY(1), yet insert longer values: three bytes in every row of the ASOF tests' tables, and three bytes and a 27-byte gzip blob in the illegal-argument tests' table. The static engine keeps such values whole, so the tests pass, but their input does not fit their schema, and a pipeline that checks the declared width on input refuses these rows. The columns now take the type of the values the tests insert: - The ASOF tables declare `bin BINARY(3)`, the width of every value they hold. - The illegal-argument table declares `bin VARBINARY`, since its values differ in length. The expected outputs stay as they are. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Contributor
|
LGTM — only test schemas change, and every What I ran
No gates fail. This is a test-only change, so no new tests or docs are needed. |
mihaibudiu
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two aggtest tables declare
bin BINARY, which SQL reads as BINARY(1), yet insert longer values: three bytes in every row of the ASOF tests' tables, and three bytes and a 27-byte gzip blob in the illegal-argument tests' table. The engine keeps such values whole, so the tests pass, but their input does not fit their schema, and a pipeline that checks the declared width on input refuses these rows.The columns now take the type of the values the tests insert:
bin BINARY(3), the width of every value they hold.bin VARBINARY, since its values differ in length.The expected outputs stay as they are.
Linked Issue
Describe Manual Test Plan
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes