Repository navigation
[pipeline-manager] Forward the IRSA variables to cargo for sccache - #8010
Merged
Merged
Conversation
sccache 0.18 reads the IAM role of the pod only from AWS_ROLE_ARN and AWS_WEB_IDENTITY_TOKEN_FILE. Earlier versions also read the role from the AWS profile that the compiler server entrypoint writes. Cargo inherited only AWS_PROFILE, so a sccache server that cargo started had no credentials. The server waited on the instance metadata service until the client gave up with "Timed out waiting for server startup", and each compilation failed until the compiler pod restarted. Cargo now also inherits AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE, AWS_REGION and AWS_STS_REGIONAL_ENDPOINTS. None of them is a credential, and a build script can already read the role and the token file path from the AWS config file. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Contributor
|
LGTM. What I ran:
|
bestouff
approved these changes
Nov 19, 2026
bestouff
left a comment
Contributor
There was a problem hiding this comment.
Swanand said that Claude said LGTM, so here we are
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
Contributor
|
Verdict: flaky test, not this PR. High confidence — the only failed job's test is unrelated to the diff, which touches only Evidence
Filed#8011 — assigned to the test's original author. Next stepRe-queueing should pass; this isn't something your change needs to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forwards a few more AWS environment variables to cargo so that sccache can authenticate in the compiler server.