← 输入框|github.com|刷新
Skip to content

[pipeline-manager] Forward the IRSA variables to cargo for sccache - #8010

Merged
gz merged 1 commit into
mainfrom
sccache-irsa-env
Nov 19, 2026
Merged

gz merged 1 commit into
mainfrom
sccache-irsa-env

Conversation

@gz

@gz gz commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Forwards a few more AWS environment variables to cargo so that sccache can authenticate in the compiler server.

sccache 0.18 reads the IAM role of the pod only from AWS_ROLE_ARN and
AWS_WEB_IDENTITY_TOKEN_FILE. Earlier versions also read the role from the
AWS profile that the compiler server entrypoint writes. Cargo inherited only
AWS_PROFILE, so a sccache server that cargo started had no credentials. The
server waited on the instance metadata service until the client gave up with
"Timed out waiting for server startup", and each compilation failed until
the compiler pod restarted.

Cargo now also inherits AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE, AWS_REGION
and AWS_STS_REGIONAL_ENDPOINTS. None of them is a credential, and a build
script can already read the role and the token file path from the AWS config
file.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

LGTM.

What I ran:

Check Result
cargo test --locked -p pipeline-manager --lib sccache / cargo_inherits pass (2/2, includes the new test)
pre-commit run --files rust_compiler.rs pass
  • Security: I found no new exposure. A build script could already find the token file through the AWS config file, and AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN stay filtered out. The new test checks this.
  • Missing (medium): the unit test only covers the filter. It does not show that sccache 0.18 actually authenticates through IRSA with these variables, and I couldn't check that without a pod. The PR description doesn't mention any manual testing on a real compiler pod either. Please add a line about it, since that is the only proof that the "Timed out waiting for server startup" failure is gone.

@gz
gz requested a review from swanandx November 19, 2026 00:19

@bestouff bestouff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swanand said that Claude said LGTM, so here we are

@gz
gz added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@mythical-fred-oss

Copy link
Copy Markdown
Contributor

Verdict: flaky test, not this PR. High confidence — the only failed job's test is unrelated to the diff, which touches only pipeline-manager/src/compiler/rust_compiler.rs.

Evidence

  • Failed job: Adapter Tests / Test Adapters (arm64)
  • Panic: controller::test::restored_adhoc_insert_after_replay at crates/connectors/src/controller/test.rs:3876 — assertion left == right failed, left: 1, right: 2 (log line 2712)
  • This job has failed with a different single test (out of ~778) on several recent main-targeted runs (44218517056, 44164955817, 44158059483) — looks like general timing/resource flakiness in the shared test runner, not specific to this test or this PR.

Filed

#8011 — assigned to the test's original author.

Next step

Re-queueing should pass; this isn't something your change needs to fix.

@gz
gz added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 42a79b1 Nov 19, 2026
3 checks passed
@gz
gz deleted the sccache-irsa-env branch November 19, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants