← 输入框|github.com|刷新
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fixing Checks GraphQL query on GitHub Enterprise - #2122

Merged
StanleyGoldman merged 7 commits into
masterfrom
fix-checks-enterprise-nulls
Dec 12, 2018
Merged

StanleyGoldman merged 7 commits into
masterfrom
fix-checks-enterprise-nulls

Conversation

@StanleyGoldman

@StanleyGoldman StanleyGoldman commented Dec 11, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #2117

  • Adding the appropriate null checks in GraphQL against GitHub Enterprise
  • Hiding the Checks display in the event that there are no Checks to display

@grokys grokys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding a HasChecks property you can use the CountToVisibilityConverter.

@StanleyGoldman
StanleyGoldman merged commit a4d7eb5 into master Dec 12, 2018
@StanleyGoldman
StanleyGoldman deleted the fix-checks-enterprise-nulls branch December 12, 2018 14:01
@MilosAuder

Copy link
Copy Markdown

Thank you for fixing this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants