Repository navigation
Fix check-query-ids reporting files as duplicates of themselves - #22898
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the query-path deduplication change.
No open issues 🎉
What changed in this PR
Fixes false duplicate-query-ID reports when a query’s path contains multiple src directories.
Changes:
- Deduplicates glob results so each query file is checked only once.
- Sorts paths for deterministic processing and documents the glob behavior.
| File | Description |
|---|---|
misc/scripts/check-query-ids.py |
Deduplicates and sorts discovered query paths to prevent self-duplicate reports. |
Review effort: Max
aschackmull
approved these changes
Oct 27, 2026
Contributor
|
Thanks, I think I've seen this issue a few times in recent days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path().glob("**/src/**/*.ql")returns the same file twice when its path contains twosrcfolders. This resulted in spurious failures for files are underjavascript/ql/src/experimental/heuristics/ql/src/....Should fix the spurious CI failure seen in #22879