← 输入框|github.com|刷新
Skip to content

[Chore]: Update workflow to run on ruby 3.4, and drop EOL ruby versions - #69

Merged
vcsjones merged 2 commits into
masterfrom
update-ci-jobs
Jan 6, 2025
Merged

vcsjones merged 2 commits into
masterfrom
update-ci-jobs

Conversation

@vcsjones

@vcsjones vcsjones commented Jan 6, 2025 •

Copy link
Copy Markdown
Member
  1. This adds ruby 3.4 to our run matrix.
  2. This drops 2.7 and 3.0. They are EOL.
  3. Update the ruby/setup-ruby action with a new pinned SHA that supports Ruby 3.4.x.
  4. Increase the minimum ruby version, and bump the gem version to 2.0.

Copilot AI review requested due to automatic review settings January 6, 2025 19:00
@vcsjones
vcsjones requested review from a team as code owners January 6, 2025 19:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

rzhade3
rzhade3 previously approved these changes Jan 6, 2025
@rzhade3

rzhade3 commented Jan 6, 2025

Copy link
Copy Markdown

@vcsjones Given that we're no longer supporting anything < 3.1 after this PR, might we want to update the minimum supported Ruby version in the Gemspec file as well?

s.required_ruby_version = ">= 2.3"

@vcsjones

vcsjones commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

@rzhade3 I think that is reasonable. It constitutes a breaking change, so we might as well bump the gem version to 2.0 while we are here.

@vcsjones
vcsjones requested a review from rzhade3 January 6, 2025 19:16
@vcsjones
vcsjones merged commit e563174 into master Jan 6, 2025
@vcsjones
vcsjones deleted the update-ci-jobs branch January 6, 2025 19:25

@BtaStore0 BtaStore0 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update-ci-jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants