Repository navigation
fix/current directory file parent #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| from git.util import assure_directory_exists | ||
| from test.lib.fixtures import writable_fixture | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def directory_fixture(monkeypatch): | ||
| with writable_fixture("empty.sh") as temporary: | ||
| directory = temporary.path().resolve() | ||
| with monkeypatch.context() as context: | ||
| context.chdir(directory) | ||
| yield directory | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("path_type", [str, Path]) | ||
| def test_file_in_current_directory_already_has_parent(directory_fixture, path_type): | ||
| assert assure_directory_exists(path_type("notes.txt"), is_file=True) is False | ||
| assert not (directory_fixture / "notes.txt").exists() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("path_type", [str, Path]) | ||
| def test_nested_file_creates_only_missing_parent_directories(directory_fixture, path_type): | ||
| filename = path_type("new/nested/notes.txt") | ||
| assert assure_directory_exists(filename, is_file=True) is True | ||
| assert (directory_fixture / "new/nested").is_dir() | ||
| assert not (directory_fixture / "new/nested/notes.txt").exists() | ||
| assert assure_directory_exists(filename, is_file=True) is False | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("path_type", [str, Path]) | ||
| def test_existing_directory_is_unchanged(directory_fixture, path_type): | ||
| (directory_fixture / "existing").mkdir() | ||
| assert assure_directory_exists(path_type("existing")) is False | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("path_type", [str, Path]) | ||
| def test_file_cannot_be_used_as_parent_directory(directory_fixture, path_type): | ||
| (directory_fixture / "blocked").write_text("occupied\n") | ||
| with pytest.raises(FileExistsError): | ||
| assure_directory_exists(path_type("blocked/notes.txt"), is_file=True) | ||
| assert (directory_fixture / "blocked").read_text() == "occupied\n" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.