← 输入框|github.com|刷新
Skip to content

Add test cases for JSON resource marshaling - #1908

Merged
gmlewis merged 6 commits into
google:masterfrom
sagar23sj:test-cases/active_runner_groups
Jul 8, 2021
Merged

gmlewis merged 6 commits into
google:masterfrom
sagar23sj:test-cases/active_runner_groups

Conversation

@sagar23sj

Copy link
Copy Markdown
Contributor

Resources Covered :

  • RunnerGroup
  • RunnerGroups
  • CreateRunnerGroupRequest
  • UpdateRunnerGroupRequest
  • SetRepoAccessRunnerGroupRequest
  • SetRunnerGroupRunnersRequest

Helps with issue : #55

Resource Covered: CreateRunnerGroupRequest
Resource Covered: UpdateRunnerGroupRequest
Resource Covered: SetRepoAccessRunnerGroupRequest
Updated test-case for : UpdateRunnerGroupRequest

Resouce Covered: SetRunnerGroupRunnersRequest
@google-cla google-cla Bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 22, 2021
@codecov

codecov Bot commented Jun 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1908 (1719ecb) into master (75644ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1908   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6786           
=======================================
  Hits         6627     6627           
  Misses         86       86           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75644ea...1719ecb. Read the comment docs.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis
gmlewis requested a review from wesleimp June 22, 2021 18:56
@gmlewis

gmlewis commented Jun 24, 2021

Copy link
Copy Markdown
Collaborator

Friendly ping @wesleimp

@Parker77 Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
gmlewis merged commit 4a83d0e into google:master Jul 8, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants