← 输入框|github.com|刷新
Skip to content

Handle MIME parameters in Content-Type Header - #1922

Merged
gmlewis merged 2 commits into
google:masterfrom
sagar23sj:fix/handle_mime_type
Jul 8, 2021
Merged

gmlewis merged 2 commits into
google:masterfrom
sagar23sj:fix/handle_mime_type

Conversation

@sagar23sj

Copy link
Copy Markdown
Contributor
  • Handled MIME parameters in Content-Type Header
  • Added test-cases to support the changes

Fixes: #1874

@google-cla google-cla Bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 26, 2021
@codecov

codecov Bot commented Jun 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1922 (75603e1) into master (eb2b7f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1922   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6786     6790    +4     
=======================================
+ Hits         6627     6631    +4     
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/messages.go 97.05% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2b7f4...75603e1. Read the comment docs.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis changed the title Handling MIME parameters in Content-Type Header Handle MIME parameters in Content-Type Header Jun 26, 2021
@gmlewis
gmlewis requested a review from wesleimp June 26, 2021 16:36

@Parker77 Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValidatePayload does not correctly parse mime type from Content-Type header

3 participants